Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: third_party/WebKit/Source/core/frame/FrameHost.cpp

Issue 2738703003: Move FrameHost::m_consoleMessageStorage to Page (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameHost.h ('k') | third_party/WebKit/Source/core/page/Page.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameHost.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameHost.cpp b/third_party/WebKit/Source/core/frame/FrameHost.cpp
index 46029a6045a13085df79ac133c4ccc809c127800..079454a00b08168e75428d25bbced27b2056f94c 100644
--- a/third_party/WebKit/Source/core/frame/FrameHost.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameHost.cpp
@@ -31,7 +31,6 @@
#include "core/frame/FrameHost.h"
#include "core/frame/FrameView.h"
-#include "core/inspector/ConsoleMessageStorage.h"
#include "core/page/Page.h"
#include "core/page/scrolling/OverscrollController.h"
#include "public/platform/Platform.h"
@@ -48,7 +47,6 @@ FrameHost::FrameHost(Page& page)
m_overscrollController(
OverscrollController::create(m_page->visualViewport(),
m_page->chromeClient())),
- m_consoleMessageStorage(new ConsoleMessageStorage()),
m_subframeCount(0) {}
// Explicitly in the .cpp to avoid default constructor in .h
@@ -79,17 +77,16 @@ const OverscrollController& FrameHost::overscrollController() const {
}
ConsoleMessageStorage& FrameHost::consoleMessageStorage() {
- return *m_consoleMessageStorage;
+ return page().consoleMessageStorage();
}
const ConsoleMessageStorage& FrameHost::consoleMessageStorage() const {
- return *m_consoleMessageStorage;
+ return page().consoleMessageStorage();
}
DEFINE_TRACE(FrameHost) {
visitor->trace(m_page);
visitor->trace(m_overscrollController);
- visitor->trace(m_consoleMessageStorage);
}
#if DCHECK_IS_ON()
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameHost.h ('k') | third_party/WebKit/Source/core/page/Page.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698