content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2738663003: Fix TODOs related to SDK 24

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2738663003: Fix TODOs related to SDK 24 (Closed)

Patch Set: Re-revert fix TODOs related to SDK 24 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwSettings.java ('k') | ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 35bd096c3404766d08cc2c34029ef01666392dda..b22367f90cd92caf3b076d92e27c92dca6a420c2 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -2416,8 +2416,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa

/**

* @see View#onDragEvent(DragEvent)

- // TODO(hush): uncomment below when we build with API 24.

- // @TargetApi(Build.VERSION_CODES.N)

+ @TargetApi(Build.VERSION_CODES.N)

public boolean onDragEvent(DragEvent event) {

if (mNativeContentViewCore == 0 || Build.VERSION.SDK_INT <= Build.VERSION_CODES.M) {

return false;

@@ -2437,9 +2436,8 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa

StringBuilder content = new StringBuilder("");

if (event.getAction() == DragEvent.ACTION_DROP) {

- // TODO(hush): obtain dragdrop permissions (via reflection?), when dragging files into

- // Chrome/WebView is supported. Not necessary to do so for now, because only text

- // dragging is supported.

+ // TODO(hush): obtain dragdrop permissions, when dragging files into Chrome/WebView is

+ // supported. Not necessary to do so for now, because only text dragging is supported.

ClipData clipData = event.getClipData();

final int itemCount = clipData.getItemCount();

for (int i = 0; i < itemCount; i++) {