Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: components/favicon/core/favicon_handler.h

Issue 2738663002: FaviconHandler test rewrite
Patch Set: Merge branch 'mastiz_cl' into favicon_handler_unittest2 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/core/favicon_handler.h
diff --git a/components/favicon/core/favicon_handler.h b/components/favicon/core/favicon_handler.h
index e7a13bbb8d08a03166d910ab0330d170854c488b..9813d9f3c377898da4585a4508e12e13d88cd704 100644
--- a/components/favicon/core/favicon_handler.h
+++ b/components/favicon/core/favicon_handler.h
@@ -131,6 +131,10 @@ class FaviconHandler {
void OnUpdateFaviconURL(const GURL& page_url,
const std::vector<favicon::FaviconURL>& candidates);
+ // Get the maximal icon size in pixels for a icon of type |icon_type| for the
+ // current platform. Public for testing.
+ static int GetMaximalIconSize(favicon_base::IconType icon_type);
+
// For testing.
const std::vector<favicon::FaviconURL>& image_urls() const {
return image_urls_;
@@ -173,9 +177,6 @@ class FaviconHandler {
virtual bool ShouldSaveFavicon();
private:
- // For testing:
- friend class TestFaviconHandler;
-
// Represents an in progress download of an image from the renderer.
struct DownloadRequest {
DownloadRequest();
@@ -207,10 +208,6 @@ class FaviconHandler {
static int GetIconTypesFromHandlerType(
FaviconDriverObserver::NotificationIconType handler_type);
- // Get the maximal icon size in pixels for a icon of type |icon_type| for the
- // current platform.
- static int GetMaximalIconSize(favicon_base::IconType icon_type);
-
// Called when the history request for favicon data mapped to |url_| has
// completed and the renderer has told us the icon URLs used by |url_|
void OnGotInitialHistoryDataAndIconURLCandidates();
« no previous file with comments | « no previous file | components/favicon/core/favicon_handler.cc » ('j') | components/favicon/core/favicon_handler_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698