Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2738663002: FaviconHandler test rewrite

Created:
3 years, 9 months ago by pkotwicz
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FaviconHandler test rewrite

Patch Set 1 #

Patch Set 2 : Merge branch 'mastiz_cl' into favicon_handler_unittest2 #

Total comments: 19
Unified diffs Side-by-side diffs Delta from patch set Stats (+1173 lines, -1480 lines) Patch
M components/favicon/core/favicon_handler.h View 3 chunks +4 lines, -7 lines 0 comments Download
M components/favicon/core/favicon_handler.cc View 3 chunks +30 lines, -36 lines 0 comments Download
M components/favicon/core/favicon_handler_unittest.cc View 6 chunks +1139 lines, -1437 lines 19 comments Download

Messages

Total messages: 1 (0 generated)
pkotwicz
3 years, 9 months ago (2017-03-10 05:47:02 UTC) #1 
Looks like I am missing tests for MultipleFaviconsAll404 and FaviconInvalidURL

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
File components/favicon/core/favicon_handler_unittest.cc (right):

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:442:
TEST_F(FaviconHandlerTest, UpdateAndDownloadFaviconDbResultBeforeCandidates) {
GetFaviconFromHistory

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:508:
TEST_F(FaviconHandlerTest, ShouldIgnoreDownloadDataForNonCandidateUrls) {
UpdateDuringDownloading

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:549:
TEST_F(FaviconHandlerTest, UpdateSameIconURLsShouldBeNoop) {
UpdateSameIconURLs

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:590:
UpdateSameIconURLsWhileHandlerProcessingShouldBeNoop) {
UpdateSameIconURLs

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:683:
TEST_F(FaviconHandlerTest, ExpiredDbPageUrl) {
DownloadFavicon

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:749:
TEST_F(FaviconHandlerTest, InvalidDataForPageUrlInDb) {
FaviconInHistoryInvalid

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:838:
TEST_F(FaviconHandlerTest, ShouldCallUnableToDownloadFaviconFor404) {
ContentFaviconDriverTest.ShouldNotRequestRepeatedlyIfUnavailable

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:866:
TEST_F(FaviconHandlerTest, ShouldCompleteWhenUnableToDownloadFirstCandidate) {
MultipleFavicons404

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:888:
TEST_F(FaviconHandlerTest, ShouldCompleteWhenUnableToDownloadLastCandidate) {
MultipleFavicons404

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:913:
TEST_F(FaviconHandlerTest, ShouldCallOnFaviconAvailableAfterIconURLChange) {
OnFaviconAvailableNotificationSentAfterIconURLChange

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:1004:
TEST_F(FaviconHandlerTest, ChooseLargestExactMatch) {
MultipleFavicons

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:1014:
TEST_F(FaviconHandlerTest, ChooseExactMatchDespiteUpsampling) {
MultipleFavicons

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:1024:
TEST_F(FaviconHandlerTest, ChooseMinorDownsamplingOverHugeIcon) {
MultipleFavicons

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:1030:
TEST_F(FaviconHandlerTest, ChooseMinorUpsamplingOverHugeIcon) {
MultipleFavicons

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:1041:
TEST_F(FaviconHandlerTest, TestLargestHandlerSortsCandidates) {
TestSortFavicon

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:1175:
TEST_F(FaviconHandlerTest, TestSelectLargestFaviconFromMultiResolutionIco) {
TestSelectLargestFavicon

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:1203:
TEST_F(FaviconHandlerTest, TestFaviconWasScaledAfterDownload) {
TestFaviconWasScaledAfterDownload

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:1273:
TEST_F(FaviconHandlerTest, TestDownloadManySelectLargest) {
TestKeepDownloadedLargestFavicon

https://codereview.chromium.org/2738663002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler_unittest.cc:1299:
TEST_F(FaviconHandlerTest, OnlyDownloadMatchingIconType) {
Download2ndFaviconURLCandidate

Powered by Google App Engine
This is Rietveld 408576698