Implement error page commit policy in PlzNavigate.

chrome/test/data/extensions/api_test/webrequest/test_blocking.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var pass = chrome.test.callbackPass;
 
 // Constants as functions, not to be called until after runTests.
 function getURLEchoUserAgent() {
   return getServerURL('echoheader?User-Agent');
 }
@@ skipping 18 matching lines @@
   for (var i = 0; i < str.length; ++i) {
     result[i] = str.charCodeAt(i);
   }
   return result;
 }
 
 runTests([
   // Navigates to a page with subresources, with a blocking handler that
   // cancels the page request. The page will not load, and we should not
   // see the subresources.
-  function complexLoadCancelled() {
-    expect(
-      [  // events
-        { label: "onBeforeRequest",
-          event: "onBeforeRequest",
-          details: {
-            type: "main_frame",
-            url: getURL("complexLoad/b.html"),
-            frameUrl: getURL("complexLoad/b.html")
-          },
-          retval: {cancel: true}
-        },
-        // Cancelling is considered an error.
-        { label: "onErrorOccurred",
-          event: "onErrorOccurred",
-          details: {
-            url: getURL("complexLoad/b.html"),
-            fromCache: false,
-            error: "net::ERR_BLOCKED_BY_CLIENT"
-            // Request to chrome-extension:// url has no IP.
-          }
-        },
-      ],
-      [  // event order
-        ["onBeforeRequest", "onErrorOccurred"]
-      ],
-      {urls: ["<all_urls>"]},  // filter
-      ["blocking"]);
-    navigateAndWait(getURL("complexLoad/b.html"));
-  },
-
-  // Navigates to a page with subresources, with a blocking handler that
-  // cancels the page request. The page will not load, and we should not
-  // see the subresources.
   function simpleLoadCancelledOnReceiveHeaders() {
     expect(
       [  // events
         { label: "onBeforeRequest",
           event: "onBeforeRequest",
           details: {
             method: "GET",
             type: "main_frame",
             url: getURLHttpSimpleLoad(),
             frameUrl: getURLHttpSimpleLoad()
@@ skipping 35 matching lines @@
       ],
       [  // event order
         ["onBeforeRequest", "onBeforeSendHeaders", "onSendHeaders",
          "onHeadersReceived", "onErrorOccurred"]
       ],
       {urls: ["<all_urls>"]},  // filter
       ["blocking"]);
     navigateAndWait(getURLHttpSimpleLoad());
   },
 
+  // Navigates to a page with subresources, with a blocking handler that
+  // cancels the page request. The page will not load, and we should not
+  // see the subresources.

[Devlin, 2017/03/16 18:38:14]

add something like:
TODO(nasko): This test was reordered in order to accommodate an unrelated
failure (crbug.com/nnn). Once that failure is fixed, the reorder should be
reverted.

[nasko, 2017/03/16 18:47:49]

Done.

+  function complexLoadCancelled() {
+    expect(
+      [  // events
+        { label: "onBeforeRequest",
+          event: "onBeforeRequest",
+          details: {
+            type: "main_frame",
+            url: getURL("complexLoad/b.html"),
+            frameUrl: getURL("complexLoad/b.html")
+          },
+          retval: {cancel: true}
+        },
+        // Cancelling is considered an error.
+        { label: "onErrorOccurred",
+          event: "onErrorOccurred",
+          details: {
+            url: getURL("complexLoad/b.html"),
+            fromCache: false,
+            error: "net::ERR_BLOCKED_BY_CLIENT"
+            // Request to chrome-extension:// url has no IP.
+          }
+        },
+      ],
+      [  // event order
+        ["onBeforeRequest", "onErrorOccurred"]
+      ],
+      {urls: ["<all_urls>"]},  // filter
+      ["blocking"]);
+    navigateAndWait(getURL("complexLoad/b.html"));
+  },
+
   // Navigates to a page and provides invalid header information. The request
   // should continue as if the headers were not changed.
   function simpleLoadIgnoreOnBeforeSendHeadersInvalidHeaders() {
     expect(
       [  // events
         { label: "onBeforeRequest",
           event: "onBeforeRequest",
           details: {
             method: "GET",
             type: "main_frame",
@@ skipping 996 matching lines @@
     [  // event order
       ["onBeforeRequest-1", "onBeforeRedirect", "onBeforeRequest-2",
        "onBeforeSendHeaders", "onSendHeaders", "onHeadersReceived",
        "onResponseStarted", "onCompleted",
        "onBeforeRequest-3", "onErrorOccurred"],
     ],
     {urls: ["<all_urls>"], types: ['image']}, // filter
     ["blocking"]);
   navigateAndWait(frameUrl);
 }