Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4514)

Unified Diff: chrome/common/extensions/docs/server2/api_data_source.py

Issue 2738623003: Extensions: Fix DocServer assert failures. (Closed)
Patch Set: Address review. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/api_data_source.py
diff --git a/chrome/common/extensions/docs/server2/api_data_source.py b/chrome/common/extensions/docs/server2/api_data_source.py
index 67004e9ca7c5af0a849d0c9a8fb2d3edfd624371..47b1e555c1eebe62d42d467fec94a5c461ad9ec5 100644
--- a/chrome/common/extensions/docs/server2/api_data_source.py
+++ b/chrome/common/extensions/docs/server2/api_data_source.py
@@ -11,7 +11,6 @@ from file_system import FileNotFoundError
from future import All, Future
from jsc_view import CreateJSCView, GetEventByNameFromEvents
from platform_util import GetPlatforms
-from third_party.json_schema_compiler.model import UnixName
class APIDataSource(DataSource):
@@ -90,9 +89,13 @@ class APIDataSource(DataSource):
return self._GetSchemaView(platform, api)
def get_platform_schemas(platform):
+ # Internal APIs are an internal implementation detail. Do not pass them to
+ # templates.
return All([get_api_schema(platform, api)
- for api in self._platform_bundle.GetAPIModels(platform)
- .GetNames()],
+ for api in self._platform_bundle.GetAPIModels(platform)
+ .GetNames()
+ if self._platform_bundle.GetAPICategorizer(platform)
+ .GetCategory(api) != 'internal'],
except_pass=FileNotFoundError)
return All([get_platform_schemas(platform) for platform in GetPlatforms()])
« no previous file with comments | « chrome/common/extensions/docs/server2/api_categorizer.py ('k') | chrome/common/extensions/docs/server2/api_schema_graph.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698