Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: chrome/common/extensions/docs/server2/api_schema_graph.py

Issue 2738623003: Extensions: Fix DocServer assert failures. (Closed)
Patch Set: Nit. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/api_schema_graph.py
diff --git a/chrome/common/extensions/docs/server2/api_schema_graph.py b/chrome/common/extensions/docs/server2/api_schema_graph.py
index 0c90ba1d9afa4ee238316ac9ed8f6447fd8e65c5..008b397dd35a3b41b5174d7996e637368d11c40a 100644
--- a/chrome/common/extensions/docs/server2/api_schema_graph.py
+++ b/chrome/common/extensions/docs/server2/api_schema_graph.py
@@ -80,7 +80,8 @@ class APINodeCursor(object):
if self._lookup_path[-1] == 'callback':
# This is an event callback, so lookup_path[-2] is the event
# node name, thus lookup_path[-3] must be 'events'.
- assert self._lookup_path[-3] == 'events'
+ assert self._lookup_path[-3] == 'events' , 'Invalid lookup path- %s' \
Devlin 2017/03/13 20:38:18 nitty nit: Let's separate the lines so the error s
karandeepb 2017/03/14 01:02:02 Done. Again is there a formatter commonly used for
Devlin 2017/03/14 01:12:05 No formatter I'm aware of. I think there are some
+ % (self._lookup_path)
return self._lookup_path[:-1]
# This is a function parameter.
assert self._lookup_path[-2] == 'parameters'

Powered by Google App Engine
This is Rietveld 408576698