[Mac] Turn on Auto Layout for browser windows.

chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/tabs/tab_window_controller.h"
 
 #include "base/logging.h"
 #import "base/mac/sdk_forward_declarations.h"
 #import "chrome/browser/ui/cocoa/browser_window_layout.h"
 #import "chrome/browser/ui/cocoa/fast_resize_view.h"
@@ skipping 45 matching lines @@
 - (BOOL)hasDarkTheme {
   return [[self parentWindow] hasDarkTheme];
 }
 
 - (BOOL)inIncognitoModeWithSystemTheme {
   return [[self parentWindow] inIncognitoModeWithSystemTheme];
 }
 
 @end
 
+@interface ChromeContentView : NSView

[tapted, 2017/03/22 22:40:00]

comment like

// Subview of the NSWindow's contentView containing everything except the tab
strip.

[Sidney San Martín, 2017/03/22 23:29:59]

Done.

+@end
+
+@implementation ChromeContentView
+
+#pragma mark - NSView Overrides

[tapted, 2017/03/22 22:40:00]

optional: a comment here like

// NSView overrides.

or

// NSView implementation.

would be fine.  (I've never been that enamoured with `#pragma mark`, but maybe
there's some IDE integration I've never noticed that gives it meaning).


This file doesn't have a prevailing style one way or the other - maybe Robert
has opinions about this :). (I'm pretty indifferent).

[Sidney San Martín, 2017/03/22 23:29:59]

Done. Xcode likes `#pragma mark -` (there's a popup menu to browse the current
file, and this makes a nice little divider and section heading in that menu),
but we're not an Xcode-heavy team so it's not super important.

+
+// Since Auto Layout and frame-based layout behave differently in small but
+// important ways (e.g. Auto Layout can restrict window resizing, frame-based
+// layout doesn't log a warning when a view's autoresizing mask can't be
+// maintained), ensure that it's on instead of letting it depend on content.
++ (BOOL)requiresConstraintBasedLayout {
+  return YES;
+}
+
+@end
+
 @implementation TabWindowController
 
 - (id)initTabWindowControllerWithTabStrip:(BOOL)hasTabStrip
                                  titleBar:(BOOL)hasTitleBar {
   const CGFloat kDefaultWidth = 750;
   const CGFloat kDefaultHeight = 600;
 
   NSRect contentRect = NSMakeRect(60, 229, kDefaultWidth, kDefaultHeight);
   base::scoped_nsobject<FramedBrowserWindow> window(
       [[FramedBrowserWindow alloc] initWithContentRect:contentRect
                                            hasTabStrip:hasTabStrip]);
   [window setReleasedWhenClosed:YES];
   [window setAutorecalculatesKeyViewLoop:YES];
 
   if ((self = [super initWithWindow:window])) {
     [[self window] setDelegate:self];
 
-    chromeContentView_.reset([[NSView alloc]
+    chromeContentView_.reset([[ChromeContentView alloc]

[tapted, 2017/03/22 22:40:00]

I think this will capture popups, but not packaged app windows. I'm ok with
this. I think WebContentsViewCocoa is the only part of the view hierarchy that
they share, which sits in the content layer. It would probably be weird to put
requiresConstraintBasedLayout on that, since it will affect other embedders
(also WebContentsViewCocoa does an explicit layout of subviews).

(although NativeAppWindowCocoa is guilty of mashing things into [[window
contentView] superview] as well, so if packaged apps don't disappear sooner, be
aware that NativeAppWindowCocoa may switch to autolayout if that gets updated to
use FullsizeContentView the way it should).

[Sidney San Martín, 2017/03/22 23:29:59]

Oh, good to know. I may be working on that change in the near-ish future. Do you
know off the top of your head why they do that instead of using borderless
windows? It looks like it just does this for windows with AppWindow::FRAME_NONE.

         initWithFrame:NSMakeRect(0, 0, kDefaultWidth, kDefaultHeight)]);
     [chromeContentView_
         setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable];
     [chromeContentView_ setWantsLayer:YES];
     [[[self window] contentView] addSubview:chromeContentView_];
 
     tabContentArea_.reset(
         [[FastResizeView alloc] initWithFrame:[chromeContentView_ bounds]]);
     [tabContentArea_ setAutoresizingMask:NSViewWidthSizable |
                                          NSViewHeightSizable];
@@ skipping 360 matching lines @@
 
 - (void)windowWillEnterFullScreenNotification:(NSNotification*)notification {
   [[visualEffectView_ animator] setAlphaValue:0.0];
 }
 
 - (void)windowWillExitFullScreenNotification:(NSNotification*)notification {
   [[visualEffectView_ animator] setAlphaValue:1.0];
 }
 
 @end