Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/body_builder.dart

Issue 2738613005: Don't crash on generic methods. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/language_kernel.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/body_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
index 074af20e1ebcdb422b1866bbfe18411c615c3151..5fd1cf3f00627385dea90b3f985ccc33752a6e70 100644
--- a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
@@ -2163,14 +2163,17 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
@override
void endTypeVariable(Token token, Token extendsOrSuper) {
- logEvent("TypeVariable");
- // TODO(ahe): Implement this when enabling generic method syntax.
+ debugEvent("TypeVariable");
+ // TODO(ahe): Do not discard these when enabling generic method syntax.
+ pop(); // Bound.
+ pop(); // Name.
}
@override
void endTypeVariables(int count, Token beginToken, Token endToken) {
- logEvent("TypeVariables");
+ debugEvent("TypeVariables");
// TODO(ahe): Implement this when enabling generic method syntax.
+ push(NullValue.TypeVariables);
}
@override
« no previous file with comments | « no previous file | tests/language/language_kernel.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698