third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 2738573002: Streamline the presentation of ImageBitmapRenderingContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2738573002: Streamline the presentation of ImageBitmapRenderingContext (Closed)

Patch Set: Fix crash in gpu test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

index ceada6f99d70a5b970eecfcbca4b2276caba176c..319878f8b88032746fab115316fc730c883f41b0 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -5162,8 +5162,7 @@ void WebGLRenderingContextBase::texImageHelperHTMLCanvasElement(

// float/integer/sRGB internal format.

// TODO(crbug.com/622958): relax the constrains if copyTextureCHROMIUM is

// upgraded to handle more formats.

- if (!canvas->renderingContext() ||

- !canvas->renderingContext()->isAccelerated() ||

+ if (!canvas->isAccelerated() ||

!canUseTexImageByGPU(functionID, internalformat, type)) {

// 2D canvas has only FrontBuffer.

texImageImpl(functionID, target, level, internalformat, xoffset, yoffset,