third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h - Issue 2738573002: Streamline the presentation of ImageBitmapRenderingContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

Issue 2738573002: Streamline the presentation of ImageBitmapRenderingContext (Closed)

Patch Set: Fixed expectations Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp ('k') | third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

index 7991a2bfa1749da54b98ad524b07383136c66aea..d29d286f2409e30c9cfd3699fd4f87698bc5116c 100644

--- a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

+++ b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

@@ -122,7 +122,8 @@ class CORE_EXPORT CanvasRenderingContext

SnapshotReason) const = 0;

virtual ImageData* toImageData(SnapshotReason reason) { return nullptr; }

virtual ContextType getContextType() const = 0;

- virtual bool isAccelerated() const { return false; }

+ virtual bool isComposited() const = 0;

+ virtual bool isAccelerated() const = 0;

virtual bool shouldAntialias() const { return false; }

virtual void setIsHidden(bool) = 0;

virtual bool isContextLost() const { return true; }

@@ -132,6 +133,7 @@ class CORE_EXPORT CanvasRenderingContext

}

virtual bool isPaintable() const = 0;

virtual void didDraw(const SkIRect& dirtyRect);

+ virtual void didDraw();

// Return true if the content is updated.

virtual bool paintRenderingResultsToCanvas(SourceDrawingBuffer) {