Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

Issue 2738533003: Use "entered or microtask context" instead of "entered or current context" (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Binding.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
index 223e6da90195dab6b3a4283ddfc273f19d3fd647..5e5b1bec44996c9417eab0440084932643e50d56 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
@@ -725,24 +725,6 @@ DOMWindow* toDOMWindow(v8::Local<v8::Context> context) {
LocalDOMWindow* enteredDOMWindow(v8::Isolate* isolate) {
LocalDOMWindow* window =
- toLocalDOMWindow(toDOMWindow(isolate->GetEnteredContext()));
- if (!window) {
- // We don't always have an entered DOM window, for example during microtask
- // callbacks from V8 (where the entered context may be the DOM-in-JS
- // context). In that case, we fall back to the current context.
- //
- // TODO(haraken): It's nasty to return a current window from
- // enteredDOMWindow. All call sites should be updated so that it works even
- // if it doesn't have an entered window. Consider using
- // enteredOrMicrotaskDOMWindow everywhere.
- window = currentDOMWindow(isolate);
- ASSERT(window);
- }
- return window;
-}
-
-LocalDOMWindow* enteredOrMicrotaskDOMWindow(v8::Isolate* isolate) {
- LocalDOMWindow* window =
toLocalDOMWindow(toDOMWindow(isolate->GetEnteredOrMicrotaskContext()));
DCHECK(window);
return window;
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Binding.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698