Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2738513007: Split NativeDataImpl (Closed)

Created:
3 years, 9 months ago by Johnni Winther
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split NativeDataImpl - into NativeClassDataImpl and NativeDataImpl R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/69130277efb0c98bc8532e07e66be64696fdc043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -152 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 3 chunks +7 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 5 chunks +15 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/native_data.dart View 13 chunks +196 lines, -135 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/native/resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/native_data_test.dart View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 9 months ago (2017-03-07 13:38:40 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 9 months ago (2017-03-14 05:29:26 UTC) #3
Johnni Winther
3 years, 9 months ago (2017-03-15 12:54:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
69130277efb0c98bc8532e07e66be64696fdc043 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698