Prepare for ICU's switch to char16_t

src/runtime/runtime-i18n.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 #ifdef V8_I18N_SUPPORT
 #include "src/runtime/runtime-utils.h"
 
 #include <memory>
 
@@ skipping 25 matching lines @@
 #include "unicode/rbbi.h"
 #include "unicode/smpdtfmt.h"
 #include "unicode/timezone.h"
 #include "unicode/translit.h"
 #include "unicode/uchar.h"
 #include "unicode/ucol.h"
 #include "unicode/ucurr.h"
 #include "unicode/uloc.h"
 #include "unicode/unistr.h"
 #include "unicode/unum.h"
+#include "unicode/ustring.h"
+#include "unicode/uvernum.h"
 #include "unicode/uversion.h"
 
 
 namespace v8 {
 namespace internal {
 namespace {
 
 const UChar* GetUCharBufferFromFlat(const String::FlatContent& flat,
                                     std::unique_ptr<uc16[]>* dest,
                                     int32_t length) {
@@ skipping 546 matching lines @@
   UCollationResult result;
   UErrorCode status = U_ZERO_ERROR;
   {
     DisallowHeapAllocation no_gc;
     int32_t length1 = string1->length();
     int32_t length2 = string2->length();
     String::FlatContent flat1 = string1->GetFlatContent();
     String::FlatContent flat2 = string2->GetFlatContent();
     std::unique_ptr<uc16[]> sap1;
     std::unique_ptr<uc16[]> sap2;
+#if U_ICU_VERSION_MAJOR_NUM < 59
     const UChar* string_val1 = GetUCharBufferFromFlat(flat1, &sap1, length1);
     const UChar* string_val2 = GetUCharBufferFromFlat(flat2, &sap2, length2);
+#else
+    const char16_t* string_val1 = reinterpret_cast<const char16_t*>(
+        GetUCharBufferFromFlat(flat1, &sap1, length1));
+    const char16_t* string_val2 = reinterpret_cast<const char16_t*>(
+        GetUCharBufferFromFlat(flat2, &sap2, length2));

[jungshik at Google, 2017/03/08 22:56:53]

Markus, can you change (or add an overload to) icu::Collator::compare to take
Char16Ptr instead of char16_t?  Then, I can get rid of this reinterpret_cast
(with an undefined behavior when the spec is interpreted strictly. ubsan may
catch this as well)?  

+#endif
     result =
         collator->compare(string_val1, length1, string_val2, length2, status);
   }
   if (U_FAILURE(status)) return isolate->ThrowIllegalOperation();
 
   return *isolate->factory()->NewNumberFromInt(result);
 }
 
 
 RUNTIME_FUNCTION(Runtime_StringNormalize) {
@@ skipping 556 matching lines @@
   Handle<FixedArray> date_cache_version =
       Handle<FixedArray>::cast(isolate->eternal_handles()->GetSingleton(
           EternalHandles::DATE_CACHE_VERSION));
   return date_cache_version->get(0);
 }
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_I18N_SUPPORT