Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Side by Side Diff: src/api.cc

Issue 2738503006: [inspector] don't make v8::debug::Call for breakProgram. (Closed)
Patch Set: addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/debug/debug.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/api.h" 5 #include "src/api.h"
6 6
7 #include <string.h> // For memcpy, strlen. 7 #include <string.h> // For memcpy, strlen.
8 #ifdef V8_USE_ADDRESS_SANITIZER 8 #ifdef V8_USE_ADDRESS_SANITIZER
9 #include <sanitizer/asan_interface.h> 9 #include <sanitizer/asan_interface.h>
10 #endif // V8_USE_ADDRESS_SANITIZER 10 #endif // V8_USE_ADDRESS_SANITIZER
(...skipping 9088 matching lines...) Expand 10 before | Expand all | Expand 10 after
9099 } 9099 }
9100 9100
9101 void debug::ClearStepping(Isolate* v8_isolate) { 9101 void debug::ClearStepping(Isolate* v8_isolate) {
9102 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(v8_isolate); 9102 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
9103 ENTER_V8(isolate); 9103 ENTER_V8(isolate);
9104 CHECK(isolate->debug()->CheckExecutionState()); 9104 CHECK(isolate->debug()->CheckExecutionState());
9105 // Clear all current stepping setup. 9105 // Clear all current stepping setup.
9106 isolate->debug()->ClearStepping(); 9106 isolate->debug()->ClearStepping();
9107 } 9107 }
9108 9108
9109 void debug::BreakRightNow(Isolate* v8_isolate) {
9110 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
9111 ENTER_V8(isolate);
9112 isolate->debug()->HandleDebugBreak(i::kIgnoreIfAllFramesBlackboxed);
9113 }
9114
9109 bool debug::AllFramesOnStackAreBlackboxed(Isolate* v8_isolate) { 9115 bool debug::AllFramesOnStackAreBlackboxed(Isolate* v8_isolate) {
9110 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(v8_isolate); 9116 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
9111 ENTER_V8(isolate); 9117 ENTER_V8(isolate);
9112 return isolate->debug()->AllFramesOnStackAreBlackboxed(); 9118 return isolate->debug()->AllFramesOnStackAreBlackboxed();
9113 } 9119 }
9114 9120
9115 v8::Isolate* debug::Script::GetIsolate() const { 9121 v8::Isolate* debug::Script::GetIsolate() const {
9116 return reinterpret_cast<v8::Isolate*>(Utils::OpenHandle(this)->GetIsolate()); 9122 return reinterpret_cast<v8::Isolate*>(Utils::OpenHandle(this)->GetIsolate());
9117 } 9123 }
9118 9124
(...skipping 1125 matching lines...) Expand 10 before | Expand all | Expand 10 after
10244 Address callback_address = 10250 Address callback_address =
10245 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback)); 10251 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
10246 VMState<EXTERNAL> state(isolate); 10252 VMState<EXTERNAL> state(isolate);
10247 ExternalCallbackScope call_scope(isolate, callback_address); 10253 ExternalCallbackScope call_scope(isolate, callback_address);
10248 callback(info); 10254 callback(info);
10249 } 10255 }
10250 10256
10251 10257
10252 } // namespace internal 10258 } // namespace internal
10253 } // namespace v8 10259 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/debug/debug.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698