Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: base/debug/activity_tracker_unittest.cc

Issue 2738493004: Support zero-sized values. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug/activity_tracker.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/activity_tracker_unittest.cc
diff --git a/base/debug/activity_tracker_unittest.cc b/base/debug/activity_tracker_unittest.cc
index c46b81686b9147abc18266e0ac7dbc3166075688..aced4fb36a1169154b028a7ee5afd0610ae3ae3c 100644
--- a/base/debug/activity_tracker_unittest.cc
+++ b/base/debug/activity_tracker_unittest.cc
@@ -91,34 +91,38 @@ TEST_F(ActivityTrackerTest, UserDataTest) {
char buffer[256];
memset(buffer, 0, sizeof(buffer));
ActivityUserData data(buffer, sizeof(buffer));
- ASSERT_EQ(sizeof(buffer) - 8, data.available_);
+ const size_t space = sizeof(buffer) - 8;
+ ASSERT_EQ(space, data.available_);
data.SetInt("foo", 1);
- ASSERT_EQ(sizeof(buffer) - 8 - 24, data.available_);
+ ASSERT_EQ(space - 24, data.available_);
data.SetUint("b", 1U); // Small names fit beside header in a word.
- ASSERT_EQ(sizeof(buffer) - 8 - 24 - 16, data.available_);
+ ASSERT_EQ(space - 24 - 16, data.available_);
data.Set("c", buffer, 10);
- ASSERT_EQ(sizeof(buffer) - 8 - 24 - 16 - 24, data.available_);
+ ASSERT_EQ(space - 24 - 16 - 24, data.available_);
data.SetString("dear john", "it's been fun");
- ASSERT_EQ(sizeof(buffer) - 8 - 24 - 16 - 24 - 32, data.available_);
+ ASSERT_EQ(space - 24 - 16 - 24 - 32, data.available_);
data.Set("c", buffer, 20);
- ASSERT_EQ(sizeof(buffer) - 8 - 24 - 16 - 24 - 32, data.available_);
+ ASSERT_EQ(space - 24 - 16 - 24 - 32, data.available_);
data.SetString("dear john", "but we're done together");
- ASSERT_EQ(sizeof(buffer) - 8 - 24 - 16 - 24 - 32, data.available_);
+ ASSERT_EQ(space - 24 - 16 - 24 - 32, data.available_);
data.SetString("dear john", "bye");
- ASSERT_EQ(sizeof(buffer) - 8 - 24 - 16 - 24 - 32, data.available_);
+ ASSERT_EQ(space - 24 - 16 - 24 - 32, data.available_);
data.SetChar("d", 'x');
- ASSERT_EQ(sizeof(buffer) - 8 - 24 - 16 - 24 - 32 - 8, data.available_);
+ ASSERT_EQ(space - 24 - 16 - 24 - 32 - 8, data.available_);
data.SetBool("ee", true);
- ASSERT_EQ(sizeof(buffer) - 8 - 24 - 16 - 24 - 32 - 8 - 16, data.available_);
+ ASSERT_EQ(space - 24 - 16 - 24 - 32 - 8 - 16, data.available_);
+
+ data.SetString("f", "");
+ ASSERT_EQ(space - 24 - 16 - 24 - 32 - 8 - 16 - 8, data.available_);
}
TEST_F(ActivityTrackerTest, PushPopTest) {
« no previous file with comments | « base/debug/activity_tracker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698