Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2738433002: Rename parser tests that use 'type arguments', but named 'type parameters'. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename parser tests that use 'type arguments', but named 'type parameters'. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/05852a662521d0e715f2be2d9043c58c21102e69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -35 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 2 chunks +16 lines, -16 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 15 chunks +17 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 9 months ago (2017-03-06 17:37:58 UTC) #1
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-06 17:56:38 UTC) #2
scheglov
3 years, 9 months ago (2017-03-06 18:04:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
05852a662521d0e715f2be2d9043c58c21102e69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698