Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 273843004: Fix file path notification filtering on Windows. (Closed)

Created:
6 years, 7 months ago by vandebo (ex-Chrome)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Fix file path notification filtering on Windows. first_notification_ was getting reset on each notification in UpdateWatch, causing the filtering to be less effective than it should have been. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271414

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M base/files/file_path_watcher_win.cc View 1 3 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
vandebo (ex-Chrome)
6 years, 7 months ago (2014-05-13 23:52:26 UTC) #1
Mattias Nissler (ping if slow)
LGTM with a nit. https://codereview.chromium.org/273843004/diff/1/base/files/file_path_watcher_win.cc File base/files/file_path_watcher_win.cc (right): https://codereview.chromium.org/273843004/diff/1/base/files/file_path_watcher_win.cc#newcode169 base/files/file_path_watcher_win.cc:169: last_modified_ != file_info.last_modified)) { nit: ...
6 years, 7 months ago (2014-05-14 10:27:52 UTC) #2
vandebo (ex-Chrome)
https://codereview.chromium.org/273843004/diff/1/base/files/file_path_watcher_win.cc File base/files/file_path_watcher_win.cc (right): https://codereview.chromium.org/273843004/diff/1/base/files/file_path_watcher_win.cc#newcode169 base/files/file_path_watcher_win.cc:169: last_modified_ != file_info.last_modified)) { On 2014/05/14 10:27:52, Mattias Nissler ...
6 years, 7 months ago (2014-05-14 16:55:40 UTC) #3
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 7 months ago (2014-05-14 16:55:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/273843004/20001
6 years, 7 months ago (2014-05-14 16:56:13 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 18:37:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 18:53:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/26691)
6 years, 7 months ago (2014-05-14 18:53:32 UTC) #8
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 7 months ago (2014-05-14 20:04:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/273843004/20001
6 years, 7 months ago (2014-05-14 20:06:56 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 20:56:59 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 21:12:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/31493)
6 years, 7 months ago (2014-05-14 21:12:39 UTC) #13
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 7 months ago (2014-05-19 16:27:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/273843004/20001
6 years, 7 months ago (2014-05-19 16:28:08 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 17:38:28 UTC) #16
Message was sent while issue was closed.
Change committed as 271414

Powered by Google App Engine
This is Rietveld 408576698