|
|
Created:
6 years, 7 months ago by vandebo (ex-Chrome) Modified:
6 years, 7 months ago CC:
chromium-reviews, erikwright+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionFix file path notification filtering on Windows.
first_notification_ was getting reset on each notification in UpdateWatch,
causing the filtering to be less effective than it should have been.
BUG=NONE
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271414
Patch Set 1 #
Total comments: 2
Patch Set 2 : nit #Messages
Total messages: 16 (0 generated)
LGTM with a nit. https://codereview.chromium.org/273843004/diff/1/base/files/file_path_watcher... File base/files/file_path_watcher_win.cc (right): https://codereview.chromium.org/273843004/diff/1/base/files/file_path_watcher... base/files/file_path_watcher_win.cc:169: last_modified_ != file_info.last_modified)) { nit: align at ( for readability
https://codereview.chromium.org/273843004/diff/1/base/files/file_path_watcher... File base/files/file_path_watcher_win.cc (right): https://codereview.chromium.org/273843004/diff/1/base/files/file_path_watcher... base/files/file_path_watcher_win.cc:169: last_modified_ != file_info.last_modified)) { On 2014/05/14 10:27:52, Mattias Nissler wrote: > nit: align at ( for readability Oops, fixed.
The CQ bit was checked by vandebo@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/273843004/20001
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...) linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
The CQ bit was checked by vandebo@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/273843004/20001
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
The CQ bit was checked by vandebo@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/273843004/20001
Message was sent while issue was closed.
Change committed as 271414 |