Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: Source/core/css/resolver/MatchedPropertiesCache.h

Issue 273843003: [Oilpan]: Make StylePropertySet fully garbage collected. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review feedback Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/resolver/MatchResult.cpp ('k') | Source/core/css/resolver/MatchedPropertiesCache.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/resolver/MatchedPropertiesCache.h
diff --git a/Source/core/css/resolver/MatchedPropertiesCache.h b/Source/core/css/resolver/MatchedPropertiesCache.h
index d86bf01f856cfc35b29ce941a2c0e18c80581dd8..4450cc2242268efae2a94cd58864f27b98633286 100644
--- a/Source/core/css/resolver/MatchedPropertiesCache.h
+++ b/Source/core/css/resolver/MatchedPropertiesCache.h
@@ -23,9 +23,10 @@
#ifndef MatchedPropertiesCache_h
#define MatchedPropertiesCache_h
+#include "core/css/StylePropertySet.h"
#include "core/css/resolver/MatchResult.h"
-
#include "platform/Timer.h"
+#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
#include "wtf/HashMap.h"
#include "wtf/Noncopyable.h"
@@ -35,17 +36,30 @@ namespace WebCore {
class RenderStyle;
class StyleResolverState;
-struct CachedMatchedProperties {
- Vector<MatchedProperties> matchedProperties;
+class CachedMatchedProperties FINAL : public NoBaseWillBeGarbageCollectedFinalized<CachedMatchedProperties> {
+
+public:
+ WillBeHeapVector<MatchedProperties> matchedProperties;
MatchRanges ranges;
RefPtr<RenderStyle> renderStyle;
RefPtr<RenderStyle> parentRenderStyle;
void set(const RenderStyle*, const RenderStyle* parentStyle, const MatchResult&);
void clear();
+ void trace(Visitor* visitor) { visitor->trace(matchedProperties); }
};
+// Specialize the HashTraits for CachedMatchedProperties to check for dead
+// entries in the MatchedPropertiesCache.
+#if ENABLE(OILPAN)
+struct CachedMatchedPropertiesHashTraits : HashTraits<Member<CachedMatchedProperties> > {
+ static const WTF::WeakHandlingFlag weakHandlingFlag = WTF::WeakHandlingInCollections;
+ static bool traceInCollection(Visitor*, Member<CachedMatchedProperties>&, WTF::ShouldWeakPointersBeMarkedStrongly);
+};
+#endif
+
class MatchedPropertiesCache {
+ DISALLOW_ALLOCATION();
WTF_MAKE_NONCOPYABLE(MatchedPropertiesCache);
public:
MatchedPropertiesCache();
@@ -58,7 +72,12 @@ public:
static bool isCacheable(const Element*, const RenderStyle*, const RenderStyle* parentStyle);
+ void trace(Visitor*);
+
private:
+#if ENABLE(OILPAN)
+ typedef HeapHashMap<unsigned, Member<CachedMatchedProperties>, DefaultHash<unsigned>::Hash, HashTraits<unsigned>, CachedMatchedPropertiesHashTraits > Cache;
+#else
// Every N additions to the matched declaration cache trigger a sweep where entries holding
// the last reference to a style declaration are garbage collected.
void sweep(Timer<MatchedPropertiesCache>*);
@@ -66,9 +85,9 @@ private:
unsigned m_additionsSinceLastSweep;
typedef HashMap<unsigned, OwnPtr<CachedMatchedProperties> > Cache;
- Cache m_cache;
-
Timer<MatchedPropertiesCache> m_sweepTimer;
+#endif
+ Cache m_cache;
};
}
« no previous file with comments | « Source/core/css/resolver/MatchResult.cpp ('k') | Source/core/css/resolver/MatchedPropertiesCache.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698