Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2738423002: Handle exports of invalid types. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M pkg/front_end/lib/src/fasta/builder/builder.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/invalid_type_builder.dart View 1 chunk +9 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_kernel.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 9 months ago (2017-03-10 12:36:02 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-03-10 12:53:06 UTC) #3
ahe
3 years, 9 months ago (2017-03-10 13:19:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
03427964632072e631b5c2cb8cb6e6d78379605c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698