[Fuchsia] vmservice creates a file in /tmp named with its port.

[Fuchsia] vmservice creates a file in /tmp named with its port.

This is to allow the flutter_tool to quickly query a Fuchsia
device for the open vmservice ports.

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/23880407841e9d199e2b7ce8384248bb3da791a1

[zra, 2017-03-10 21:59:51]

Description was changed from

==========
[Fuchsia] vmservice creates a file in /tmp named with its port.
==========

to

==========
[Fuchsia] vmservice creates a file in /tmp named with its port.

This is to allow the flutter_tool to quickly query a Fuchsia
device for the open vmservice ports.
==========

[zra, 2017-03-10 22:00:43]

zra@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2017-03-10 22:03:01]

LGTM w/c

https://codereview.chromium.org/2738373003/diff/1/runtime/bin/vmservice/serve...
File runtime/bin/vmservice/server.dart (right):

https://codereview.chromium.org/2738373003/diff/1/runtime/bin/vmservice/serve...
runtime/bin/vmservice/server.dart:352: new File(path)..create(recursive: true);
should this be createSync ?

https://codereview.chromium.org/2738373003/diff/1/runtime/bin/vmservice/serve...
runtime/bin/vmservice/server.dart:375: new File(path)..delete();
should this be deleteSync?

[zra, 2017-03-10 22:22:48]

https://codereview.chromium.org/2738373003/diff/1/runtime/bin/vmservice/serve...
File runtime/bin/vmservice/server.dart (right):

https://codereview.chromium.org/2738373003/diff/1/runtime/bin/vmservice/serve...
runtime/bin/vmservice/server.dart:352: new File(path)..create(recursive: true);
On 2017/03/10 22:03:01, Cutch wrote:
> should this be createSync ?

I think it doesn't matter since the vmservice doesn't need to read or write the
file, but it won't hurt anything either, so I'll change it.

https://codereview.chromium.org/2738373003/diff/1/runtime/bin/vmservice/serve...
runtime/bin/vmservice/server.dart:375: new File(path)..delete();
On 2017/03/10 22:03:01, Cutch wrote:
> should this be deleteSync?

ditto

[zra, 2017-03-10 22:33:42]

Description was changed from

==========
[Fuchsia] vmservice creates a file in /tmp named with its port.

This is to allow the flutter_tool to quickly query a Fuchsia
device for the open vmservice ports.
==========

to

==========
[Fuchsia] vmservice creates a file in /tmp named with its port.

This is to allow the flutter_tool to quickly query a Fuchsia
device for the open vmservice ports.

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/23880407841e9d199e2b7ce8384248bb3da791a1
==========

[zra, 2017-03-10 22:33:53]

Committed patchset #2 (id:20001) manually as
23880407841e9d199e2b7ce8384248bb3da791a1 (presubmit successful).