content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 2738373002: Enhance chrome.app.window API with window background color

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 2738373002: Enhance chrome.app.window API with window background color (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index b67a5f3d160e4521c879bcdb7bf30b7fa005876a..5c0bd6131400802a9bd3d0d87562019978c17331 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -1650,6 +1650,9 @@ void RenderWidgetHostViewMac::SetBackgroundColor(SkColor color) {

if (render_widget_host_)

render_widget_host_->SetBackgroundOpaque(opaque);

+ if (opaque && color != SK_ColorWHITE)

+ render_widget_host_->SetBaseBackgroundColor(color);

[cocoa_view_ setOpaque:opaque];

browser_compositor_->SetHasTransparentBackground(!opaque);