Enhance chrome.app.window API with window background color

extensions/browser/app_window/app_window.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_H_
 #define EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 136 matching lines @@
     CreateParams(const CreateParams& other);
     ~CreateParams();
 
     WindowType window_type;
     Frame frame;
 
     bool has_frame_color;
     SkColor active_frame_color;
     SkColor inactive_frame_color;
     bool alpha_enabled;
+    SkColor background_color;
     bool is_ime_window;
 
     // The initial content/inner bounds specification (excluding any window
     // decorations).
     BoundsSpecification content_spec;
 
     // The initial window/outer bounds specification (including window
     // decorations).
     BoundsSpecification window_spec;
 
@@ skipping 189 matching lines @@
   // the renderer.
   void GetSerializedState(base::DictionaryValue* properties) const;
 
   // Notifies the window's contents that the render view is ready and it can
   // unblock resource requests.
   void NotifyRenderViewReady();
 
   // Whether the app window wants to be alpha enabled.
   bool requested_alpha_enabled() const { return requested_alpha_enabled_; }
 
+  // Set background color.

[Reilly Grant (use Gerrit), 2017/03/10 18:39:18]

This is a getter, it cannot "set" anything.

+  SkColor backgroundColor() const { return background_color_; }
+
   // Whether the app window is created by IME extensions.
   // TODO(bshe): rename to hide_app_window_in_launcher if it is not used
   // anywhere other than app_window_launcher_controller after M45. Otherwise,
   // remove this TODO.
   bool is_ime_window() const { return is_ime_window_; }
 
   bool show_in_shelf() const { return show_in_shelf_; }
 
   const GURL& window_icon_url() const { return window_icon_url_; }
 
@@ skipping 175 matching lines @@
   // Cache the desired value of the always-on-top property. When windows enter
   // fullscreen or overlap the Windows taskbar, this property will be
   // automatically and silently switched off for security reasons. It is
   // reinstated when the window exits fullscreen and moves away from the
   // taskbar.
   bool cached_always_on_top_;
 
   // Whether |alpha_enabled| was set in the CreateParams.
   bool requested_alpha_enabled_;
 
+  // Set background color

[Reilly Grant (use Gerrit), 2017/03/10 18:39:18]

As in the IDL file, please be more specific.

+  SkColor background_color_;
+
   // Whether |is_ime_window| was set in the CreateParams.
   bool is_ime_window_;
 
   // Whether |show_in_shelf| was set in the CreateParams.
   bool show_in_shelf_;
 
   // Icon URL to be used for setting the window icon. If not empty,
   // app_icon_ will be fetched and set using this URL and will have
   // app_icon_image_ as a badge.
   GURL window_icon_url_;
 
   // PlzNavigate: this is called when the first navigation is ready to commit.
   base::Closure on_first_commit_callback_;
 
   base::WeakPtrFactory<AppWindow> image_loader_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AppWindow);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_H_