Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Unified Diff: chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc

Issue 2738323003: Implement basic USB setup in the cups printer detector. Factor out (Closed)
Patch Set: Fix ppd provider lifetime. It was being inappropriately deleted which meant it caused USB resoluti… Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
diff --git a/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc b/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
index 371bea87eb7f9ead4afe5f34f883ca7b15504422..3ef058889325f4ce0e472e18ce424b515aeffcc3 100644
--- a/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
+++ b/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
@@ -242,10 +242,11 @@ void CupsPrintersHandler::HandleAddCupsPrinter(const base::ListValue* args) {
weak_factory_.GetWeakPtr(), base::Passed(&printer)));
}
-void CupsPrintersHandler::OnAddedPrinter(std::unique_ptr<Printer> printer,
- chromeos::SetupResult result_code) {
+void CupsPrintersHandler::OnAddedPrinter(
+ std::unique_ptr<Printer> printer,
+ chromeos::PrinterSetupResult result_code) {
std::string printer_name = printer->display_name();
- bool success = (result_code == chromeos::SetupResult::SUCCESS);
+ bool success = (result_code == chromeos::PrinterSetupResult::SUCCESS);
if (success) {
PrintersManagerFactory::GetForBrowserContext(profile_)->RegisterPrinter(
std::move(printer));
« no previous file with comments | « chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698