chrome/browser/chromeos/printer_detector/printer_detector_factory.cc - Issue 2738323003: Implement basic USB setup in the cups printer detector. Factor out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/printer_detector/printer_detector_factory.cc

Issue 2738323003: Implement basic USB setup in the cups printer detector. Factor out (Closed)

Patch Set: Remove dep on extensions Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/printer_detector/cups_printer_detector.cc ('K') | « chrome/browser/chromeos/printer_detector/legacy_printer_detector.cc ('k') | chrome/browser/chromeos/printing/printer_configurer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/printer_detector/printer_detector_factory.cc

diff --git a/chrome/browser/chromeos/printer_detector/printer_detector_factory.cc b/chrome/browser/chromeos/printer_detector/printer_detector_factory.cc

index 01a7b7dbbbe24074ebe59fec9c237ff3abb3d5cc..7a2cf0d6fee68e7fed251ad6f2b6b1768ac04691 100644

--- a/chrome/browser/chromeos/printer_detector/printer_detector_factory.cc

+++ b/chrome/browser/chromeos/printer_detector/printer_detector_factory.cc

@@ -6,10 +6,10 @@

#include "base/command_line.h"

#include "chrome/browser/chromeos/printer_detector/printer_detector.h"

+#include "chrome/browser/chromeos/printing/printers_manager_factory.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/common/chrome_switches.h"

#include "components/keyed_service/content/browser_context_dependency_manager.h"

-#include "extensions/browser/extensions_browser_client.h"

namespace chromeos {

@@ -34,8 +34,7 @@ PrinterDetectorFactory::PrinterDetectorFactory()

: BrowserContextKeyedServiceFactory(

"PrinterDetectorFactory",

BrowserContextDependencyManager::GetInstance()) {

- DependsOn(

- extensions::ExtensionsBrowserClient::Get()->GetExtensionSystemFactory());

tbarzic 2017/03/15 18:43:43 doesn't legacy printer detector still depend on ex

Carlson 2017/03/15 23:06:16 Ugh, got tunnel vision there for a minute, thanks

+ DependsOn(PrintersManagerFactory::GetInstance());

}

PrinterDetectorFactory::~PrinterDetectorFactory() {