Move most of kernel-service.dart to package:front_end.

Move most of kernel-service.dart to package:front_end.

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/c19b49ff2602ac50abc3e5bd365358dff2143521

[ahe, 2017-03-10 09:48:10]

ahe@google.com changed reviewers:
+ vegorov@google.com

[ahe, 2017-03-10 09:48:10]

@dart-fe-team: this is also a proposal for API to support the VM. For now, I've
put the vm.dart file in lib/src. Once the API has matured, I think it it belongs
in lib/.

[Vyacheslav Egorov (Google), 2017-03-10 09:58:15]

LGTM!

https://codereview.chromium.org/2738253003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/outline.dart (right):

https://codereview.chromium.org/2738253003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/outline.dart:209: // TODO(ahe):
https://github.com/dart-lang/sdk/issues/29027
I have filed this issue before as #28316

https://codereview.chromium.org/2738253003/diff/1/pkg/front_end/lib/src/vm.dart
File pkg/front_end/lib/src/vm.dart (right):

https://codereview.chromium.org/2738253003/diff/1/pkg/front_end/lib/src/vm.da...
pkg/front_end/lib/src/vm.dart:36: factory CompilationResult.ok(Uint8List bytes)
= _CompilationOk;
This is cool. I learned something today!

https://codereview.chromium.org/2738253003/diff/1/utils/kernel-service/kernel...
File utils/kernel-service/kernel-service.dart (right):

https://codereview.chromium.org/2738253003/diff/1/utils/kernel-service/kernel...
utils/kernel-service/kernel-service.dart:85: port.send([tag, inputFileUrl,
inputFileUrl, null, result]);
this should be result.payload too,

this was a bug in the code (this code is not tested right now because we bypass
the loader - but we will start going through this code again once Kevin splits
core libraries bootstrapping out again)

[ahe, 2017-03-10 12:05:49]

Thank you, Slava!

Notice that I moved lib/src/vm.dart to lib/src/fasta/vm.dart. This way I avoid
changing the subpackage relationships for a proposed API.

https://codereview.chromium.org/2738253003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/outline.dart (right):

https://codereview.chromium.org/2738253003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/outline.dart:209: // TODO(ahe):
https://github.com/dart-lang/sdk/issues/29027
On 2017/03/10 09:58:15, Vyacheslav Egorov (Google) wrote:
> I have filed this issue before as #28316

Done.

https://codereview.chromium.org/2738253003/diff/1/pkg/front_end/lib/src/vm.dart
File pkg/front_end/lib/src/vm.dart (right):

https://codereview.chromium.org/2738253003/diff/1/pkg/front_end/lib/src/vm.da...
pkg/front_end/lib/src/vm.dart:36: factory CompilationResult.ok(Uint8List bytes)
= _CompilationOk;
On 2017/03/10 09:58:15, Vyacheslav Egorov (Google) wrote:
> This is cool. I learned something today!

Acknowledged.

https://codereview.chromium.org/2738253003/diff/1/utils/kernel-service/kernel...
File utils/kernel-service/kernel-service.dart (right):

https://codereview.chromium.org/2738253003/diff/1/utils/kernel-service/kernel...
utils/kernel-service/kernel-service.dart:85: port.send([tag, inputFileUrl,
inputFileUrl, null, result]);
On 2017/03/10 09:58:15, Vyacheslav Egorov (Google) wrote:
> this should be result.payload too,
> 
> this was a bug in the code (this code is not tested right now because we
bypass
> the loader - but we will start going through this code again once Kevin splits
> core libraries bootstrapping out again)

Aha. I should have added a comment that I found this a bit odd.

[ahe, 2017-03-10 12:08:39]

On 2017/03/10 12:05:49, ahe wrote:
> Notice that I moved lib/src/vm.dart to lib/src/fasta/vm.dart. This way I avoid
> changing the subpackage relationships for a proposed API.

That's not very clear.

We have a test that checks that we don't introduce new dependencies between the
subdirectories of pkg/front_end. This test fails after I added vm.dart, so I
figured it was better to move it into the fasta directory since lib/src was a
temporary location for vm.dart anyways.

[ahe, 2017-03-10 12:10:34]

Description was changed from

==========
Move most of kernel-service.dart to package:front_end.
==========

to

==========
Move most of kernel-service.dart to package:front_end.

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c19b49ff2602ac50abc3e5bd365358dff2143521
==========

[ahe, 2017-03-10 12:10:36]

Committed patchset #4 (id:60001) manually as
c19b49ff2602ac50abc3e5bd365358dff2143521 (presubmit successful).

[Paul Berry, 2017-03-10 16:52:56]

On 2017/03/10 09:48:10, ahe wrote:
> @dart-fe-team: this is also a proposal for API to support the VM. For now,
I've
> put the vm.dart file in lib/src. Once the API has matured, I think it it
belongs
> in lib/.

Regarding the API to support the VM: before we switched to Fasta, the API we
were planning to use was in pkg/front_end/lib/kernel_generator.dart.  Should we
get rid of that file, or will it still be useful to other clients?  If we get
rid of it, is there any piece of it that we want to keep?  In particular, do we
want to keep any of the features described in
pkg/front_end/lib/compiler_options.dart?

[ahe, 2017-03-10 17:22:26]

On 2017/03/10 16:52:56, Paul Berry wrote:
> On 2017/03/10 09:48:10, ahe wrote:
> > @dart-fe-team: this is also a proposal for API to support the VM. For now,
> I've
> > put the vm.dart file in lib/src. Once the API has matured, I think it it
> belongs
> > in lib/.
> 
> Regarding the API to support the VM: before we switched to Fasta, the API we
> were planning to use was in pkg/front_end/lib/kernel_generator.dart.  Should
we
> get rid of that file, or will it still be useful to other clients?  If we get
> rid of it, is there any piece of it that we want to keep?  In particular, do
we
> want to keep any of the features described in
> pkg/front_end/lib/compiler_options.dart?

I completely forgot about that API. I'll try to use that API instead of moving
vm.dart to lib/.