Network traffic annotation added to device_description_fetcher.

chrome/browser/extensions/api/dial/device_description_fetcher.cc

Index: chrome/browser/extensions/api/dial/device_description_fetcher.cc
diff --git a/chrome/browser/extensions/api/dial/device_description_fetcher.cc b/chrome/browser/extensions/api/dial/device_description_fetcher.cc
index 7be4b199367e06b3110989a1a54d1c6b8467991a..dfbfc770faf6ca3dee31a0d2e591672060834c8f 100644
--- a/chrome/browser/extensions/api/dial/device_description_fetcher.cc
+++ b/chrome/browser/extensions/api/dial/device_description_fetcher.cc
@@ -13,6 +13,7 @@
 #include "net/http/http_response_headers.h"
 #include "net/http/http_status_code.h"
 #include "net/http/http_util.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_context_getter.h"
 
@@ -49,10 +50,31 @@ void DeviceDescriptionFetcher::Start() {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(!fetcher_);
 
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("...", R"(

[imcheng, 2017/03/13 19:59:42]

dial_get_device_description

[Ramin Halavati, 2017/03/13 21:44:30]

Done.

+        semantics {
+          sender: "..."

[imcheng, 2017/03/13 19:59:42]

dial

[Ramin Halavati, 2017/03/13 21:44:30]

Done.

+          description: "..."

[imcheng, 2017/03/13 19:59:42]

Chromium sends a request to a device (such as a smart TV) discovered via the
DIAL (Disovery and Launch) protocol to obtain its device description. Chromium
then uses the device description to determine the capabilities of the device to
be used as a target for casting media content.

[Ramin Halavati, 2017/03/13 21:44:30]

Done.

+          trigger: "..."

[imcheng, 2017/03/13 19:59:42]

A new or updated device has been discovered via DIAL in the local network.

[Ramin Halavati, 2017/03/13 21:44:30]

Done.

+          data: "..."

[imcheng, 2017/03/13 19:59:42]

A HTTP GET request.

[Ramin Halavati, 2017/03/13 21:44:30]

Done.

+          destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER

[imcheng, 2017/03/13 19:59:42]

I suppose this should be WEBSITE as the destination is an IP address of a device
on the local network. It returns a XML response to a HTTP GET request.

[Ramin Halavati, 2017/03/13 21:44:30]

I think it's OTHER, as it is not a website that user interacts with.

+        }
+        policy {
+          cookies_allowed: false/true

[imcheng, 2017/03/13 19:59:42]

false

[Ramin Halavati, 2017/03/13 21:44:30]

Done.

+          cookies_store: "..."
+          setting: "..."

[imcheng, 2017/03/13 19:59:42]

This (and the Media Router) can be disabled via the EnableMediaRouter policy.

[Ramin Halavati, 2017/03/13 21:44:30]

So it cannot be disabled by settings?

[imcheng, 2017/03/14 22:48:19]

You can disable it via the media-router flag but not through settings.

[Ramin Halavati, 2017/03/15 06:37:37]

Thank you.

+          chrome_policy {
+            [POLICY_NAME] {

[imcheng, 2017/03/13 19:59:42]

EnableMediaRouter

[Ramin Halavati, 2017/03/13 21:44:30]

Done.

+              policy_options {mode: MANDATORY/RECOMMENDED/UNSET}

[imcheng, 2017/03/13 19:59:42]

MANDATORY

[Ramin Halavati, 2017/03/13 21:44:30]

Done.

+              [POLICY_NAME]: ... //(value to disable it)

[imcheng, 2017/03/13 19:59:42]

false

[Ramin Halavati, 2017/03/13 21:44:30]

Done.

+            }
+          }
+          policy_exception_justification: "..."
+        })");
   // DIAL returns device descriptions via GET request.
   fetcher_ =
       net::URLFetcher::Create(kURLFetcherIDForTest, device_description_url_,
-                              net::URLFetcher::GET, this);
+                              net::URLFetcher::GET, this, traffic_annotation);
 
   // net::LOAD_BYPASS_PROXY: Proxies almost certainly hurt more cases than they
   //     help.