Chromium Code Reviews Chromium Code Reviews
Issue
273823002:
Adding gtest helpers for BeginFrameArgs. (Closed)
DescriptionAdding gtest helpers for BeginFrameArgs.
* Allow BeginFrameArgs inside an EXPECT_EQ call.
EXPECT_EQ(args1, args2)
* Allow gtest to pretty print BeginFrameArgs objects.
Output use to look like;
---------------------------------------------------
Expected: args1
Which is:
16 byte object <0xFF 0xFF 0xFF 0x01 ...>
Actual: args2
Which is:
16 byte object <0xFF 0xFF 0xFF 0x01 ...>
---------------------------------------------------
Output now looks like;
---------------------------------------------------
Expected: args1
Which is:
BeginFrameArgs(1, 2, 3)
Actual: args2
Which is:
BeginFrameArgs(1, 2, 4)
---------------------------------------------------
BUG=371223
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271413
Patch Set 1 #
Total comments: 2
Patch Set 2 : Making the operator== use const. #Patch Set 3 : Rebasing #Patch Set 4 : Adding unittest. #Patch Set 5 : Rebase. #Patch Set 6 : Rebasing onto master. #Patch Set 7 : Change EXPECT_EQ(true/false to EXPECT_TRUE/FALSE(. #
Messages
Total messages: 9 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
