Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2738223002: Reland "Turn the DOWN_CAST_COMPOSITE strong mode error into a hint, which will" (Closed)

Created:
3 years, 9 months ago by kasperl
Modified:
3 years, 9 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland "Turn the DOWN_CAST_COMPOSITE strong mode error into a hint, which will" R=vsm@google.com BUG=28588 Committed: https://github.com/dart-lang/sdk/commit/b4a5a7e825450a8828faf0009540e07e9e9891c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -78 lines) Patch
M pkg/analyzer/lib/src/error/codes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 31 chunks +74 lines, -74 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kasperl
3 years, 9 months ago (2017-03-09 14:54:17 UTC) #1
kasperl
Committed patchset #1 (id:1) manually as b4a5a7e825450a8828faf0009540e07e9e9891c1 (presubmit successful).
3 years, 9 months ago (2017-03-09 14:55:11 UTC) #3
kasperl
TBR'ed. Only change is updating to strong mode analyzer tests.
3 years, 9 months ago (2017-03-09 14:55:35 UTC) #4
vsm
3 years, 9 months ago (2017-03-09 15:16:54 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698