Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

Issue 2738163002: Enable CopyTextureCHROMIUM in Blink for Tex{Sub}Image2D with more cases (Closed)
Patch Set: rebase only--blink renaming and formatting Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp b/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp
index f95aa2359d961a13f22f6c4bf9ca8a86a4e765c3..cc37b9ed3ddc1f2ad931147fdb661beba2885528 100644
--- a/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp
+++ b/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp
@@ -66,10 +66,11 @@ void AcceleratedStaticBitmapImage::UpdateSyncToken(gpu::SyncToken sync_token) {
void AcceleratedStaticBitmapImage::CopyToTexture(
WebGraphicsContext3DProvider* dest_provider,
+ GLenum dest_target,
GLuint dest_texture_id,
- GLenum internal_format,
- GLenum dest_type,
- bool flip_y) {
+ bool flip_y,
+ const IntPoint& dest_point,
+ const IntRect& source_sub_rectangle) {
CheckThread();
if (!IsValid())
return;
@@ -82,9 +83,11 @@ void AcceleratedStaticBitmapImage::CopyToTexture(
dest_gl->WaitSyncTokenCHROMIUM(texture_holder_->GetSyncToken().GetData());
GLuint source_texture_id = dest_gl->CreateAndConsumeTextureCHROMIUM(
GL_TEXTURE_2D, texture_holder_->GetMailbox().name);
- dest_gl->CopyTextureCHROMIUM(source_texture_id, 0, GL_TEXTURE_2D,
- dest_texture_id, 0, internal_format, dest_type,
- flip_y, false, false);
+ dest_gl->CopySubTextureCHROMIUM(
+ source_texture_id, 0, dest_target, dest_texture_id, 0, dest_point.X(),
+ dest_point.Y(), source_sub_rectangle.X(), source_sub_rectangle.Y(),
+ source_sub_rectangle.Width(), source_sub_rectangle.Height(), flip_y,
+ false, false);
// This drops the |destGL| context's reference on our |m_mailbox|, but it's
// still held alive by our SkImage.
dest_gl->DeleteTextures(1, &source_texture_id);

Powered by Google App Engine
This is Rietveld 408576698