Enable CopyTextureCHROMIUM in Blink for Tex{Sub}Image2D with more cases

gpu/command_buffer/service/gles2_cmd_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdio.h>
@@ skipping 16407 matching lines @@
     bool flip_y,
     bool premultiply_alpha,
     bool unpremultiply_alpha) {
   bool premultiply_alpha_change = premultiply_alpha ^ unpremultiply_alpha;
   bool source_format_color_renderable =
       Texture::ColorRenderable(GetFeatureInfo(), source_internal_format, false);
   bool dest_format_color_renderable =
       Texture::ColorRenderable(GetFeatureInfo(), dest_internal_format, false);
   std::string output_error_msg;
 
+  // Make sure source_type has value for unsized source internalformat.
+  if (!GLES2Util::IsSizedColorFormat(source_internal_format) && !source_type) {
+    source_type =
+        TextureManager::ExtractTypeFromStorageFormat(source_internal_format);
+  }

[qiankun, 2017/03/09 08:53:02]

This code can be removed once the issue in
https://codereview.chromium.org/2711903002/ is fixed.

[Zhenyao Mo, 2017/03/10 00:10:23]

Can you add it into a TODO in the code? Otherwise it might get lost

[qiankun, 2017/03/10 02:48:04]

Done.

+  DCHECK(GLES2Util::IsSizedColorFormat(source_internal_format) || source_type);
+
   // CopyTexImage* should not allow internalformat of GL_BGRA_EXT and
   // GL_BGRA8_EXT. crbug.com/663086.
   bool copy_tex_image_format_valid =
       source_internal_format != GL_BGRA_EXT &&
       dest_internal_format != GL_BGRA_EXT &&
       source_internal_format != GL_BGRA8_EXT &&
       dest_internal_format != GL_BGRA8_EXT &&
       ValidateCopyTexFormatHelper(dest_internal_format, source_internal_format,
                                   source_type, &output_error_msg);
 
@@ skipping 2917 matching lines @@
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "base/macros.h"
 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu