Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2738133005: Make complex_reload_test use Uris instead of file paths (Closed)

Created:
3 years, 9 months ago by Cutch
Modified:
3 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make complex_reload_test use Uris instead of file paths BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/5da8b12dc6d9d020f7e8c32b04b85983a31fa9f8

Patch Set 1 #

Patch Set 2 : Use path package for dirname #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M runtime/observatory/tests/service/complex_reload_test.dart View 1 4 chunks +14 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
3 years, 9 months ago (2017-03-10 17:26:26 UTC) #3
rmacnak
lgtm
3 years, 9 months ago (2017-03-10 17:29:15 UTC) #4
Cutch
3 years, 9 months ago (2017-03-10 17:31:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5da8b12dc6d9d020f7e8c32b04b85983a31fa9f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698