third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 2738133002: Provide an overload to WebView::create that does not require a WebViewClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2738133002: Provide an overload to WebView::create that does not require a WebViewClient. (Closed)

Patch Set: Add a derived WebViewClient and use it when no client is passed. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index 4bcb8c64a50114a68bafbd7d272210df4ff084e8..5f1be7cd46d349ade075c4fdaac6206b1819bc5e 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -2100,8 +2100,7 @@ TEST_P(WebViewTest, ClientTapHandling) {

}

TEST_P(WebViewTest, ClientTapHandlingNullWebViewClient) {

- WebViewImpl* webView =

- WebViewImpl::create(nullptr, WebPageVisibilityStateVisible);

+ WebViewImpl* webView = WebViewImpl::create(WebPageVisibilityStateVisible);

FrameTestHelpers::TestWebFrameClient webFrameClient;

FrameTestHelpers::TestWebWidgetClient webWidgetClient;

WebLocalFrame* localFrame = WebLocalFrame::create(