Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 2738133002: Provide an overload to WebView::create that does not require a WebViewClient. (Closed)
Patch Set: Add a derived WebViewClient and use it when no client is passed. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/android/media_info_loader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/printing/renderer/print_web_view_helper.cc
diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc
index f31074f26bb3c9c0416adcd3acfc192795c92126..94630f6b4f4ed9d86f88edd454cae1396efd8d0d 100644
--- a/components/printing/renderer/print_web_view_helper.cc
+++ b/components/printing/renderer/print_web_view_helper.cc
@@ -582,7 +582,7 @@ void PrintWebViewHelper::PrintHeaderAndFooter(
page_layout.content_height);
blink::WebView* web_view =
- blink::WebView::create(nullptr, blink::WebPageVisibilityStateVisible);
+ blink::WebView::create(blink::WebPageVisibilityStateVisible);
web_view->settings()->setJavaScriptEnabled(true);
blink::WebFrameClient frame_client;
« no previous file with comments | « no previous file | content/renderer/media/android/media_info_loader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698