Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

Issue 2738133002: Provide an overload to WebView::create that does not require a WebViewClient. (Closed)
Patch Set: Add a derived WebViewClient and use it when no client is passed. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 m_workerInspectorProxy->workerThreadTerminated(); 119 m_workerInspectorProxy->workerThreadTerminated();
120 } 120 }
121 121
122 void WebSharedWorkerImpl::initializeLoader() { 122 void WebSharedWorkerImpl::initializeLoader() {
123 DCHECK(isMainThread()); 123 DCHECK(isMainThread());
124 124
125 // Create 'shadow page'. This page is never displayed, it is used to proxy the 125 // Create 'shadow page'. This page is never displayed, it is used to proxy the
126 // loading requests from the worker context to the rest of WebKit and Chromium 126 // loading requests from the worker context to the rest of WebKit and Chromium
127 // infrastructure. 127 // infrastructure.
128 DCHECK(!m_webView); 128 DCHECK(!m_webView);
129 m_webView = WebView::create(nullptr, WebPageVisibilityStateVisible); 129 m_webView = WebView::create(WebPageVisibilityStateVisible);
130 // FIXME: http://crbug.com/363843. This needs to find a better way to 130 // FIXME: http://crbug.com/363843. This needs to find a better way to
131 // not create graphics layers. 131 // not create graphics layers.
132 m_webView->settings()->setAcceleratedCompositingEnabled(false); 132 m_webView->settings()->setAcceleratedCompositingEnabled(false);
133 // FIXME: Settings information should be passed to the Worker process from 133 // FIXME: Settings information should be passed to the Worker process from
134 // Browser process when the worker is created (similar to 134 // Browser process when the worker is created (similar to
135 // RenderThread::OnCreateNewView). 135 // RenderThread::OnCreateNewView).
136 m_mainFrame = toWebLocalFrameImpl( 136 m_mainFrame = toWebLocalFrameImpl(
137 WebLocalFrame::create(WebTreeScopeType::Document, this, 137 WebLocalFrame::create(WebTreeScopeType::Document, this,
138 Platform::current()->interfaceProvider(), nullptr)); 138 Platform::current()->interfaceProvider(), nullptr));
139 m_webView->setMainFrame(m_mainFrame.get()); 139 m_webView->setMainFrame(m_mainFrame.get());
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 if (devtoolsAgent) 439 if (devtoolsAgent)
440 devtoolsAgent->dispatchOnInspectorBackend(sessionId, callId, method, 440 devtoolsAgent->dispatchOnInspectorBackend(sessionId, callId, method,
441 message); 441 message);
442 } 442 }
443 443
444 WebSharedWorker* WebSharedWorker::create(WebSharedWorkerClient* client) { 444 WebSharedWorker* WebSharedWorker::create(WebSharedWorkerClient* client) {
445 return new WebSharedWorkerImpl(client); 445 return new WebSharedWorkerImpl(client);
446 } 446 }
447 447
448 } // namespace blink 448 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698