Issue 2738113002: Add strong mode error for mixins defining conflicting private names (issue 28809)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2738113002: Add strong mode error for mixins defining conflicting private names (issue 28809) (Closed)

Created:
3 years, 9 months ago by Brian Wilkerson

Modified:
3 years, 9 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, keertip

Target Ref:
refs/heads/master

Visibility:
Public.

Add strong mode error for mixins defining conflicting private names (issue 28809) R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/97cc40e0a79eab42b2f5dee7d4f380079b4e5b3a

Created: 3 years, 9 months ago

	Unified diffs	Side-by-side diffs	Stats (+188 lines, -0 lines)
M	pkg/analyzer/lib/error/error.dart	View	1 chunk	+1 line, -0 lines	0 comments
M	pkg/analyzer/lib/src/error/codes.dart	View	1 chunk	+11 lines, -0 lines	0 comments
M	pkg/analyzer/lib/src/generated/error_verifier.dart	View	2 chunks	+77 lines, -0 lines	0 comments
M	pkg/analyzer/test/generated/compile_time_error_code_test.dart	View	1 chunk	+99 lines, -0 lines	0 comments

Total messages: 5 (2 generated)

Brian Wilkerson

The only difference from the last time this code was reviewed is the addition of ...

3 years, 9 months ago (2017-03-09 01:18:30 UTC) #2

Brian Wilkerson

3 years, 9 months ago (2017-03-22 15:42:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
97cc40e0a79eab42b2f5dee7d4f380079b4e5b3a (presubmit successful).