Add an argument to handleFunctionBodySkipped.

Add an argument to handleFunctionBodySkipped.

This is necessary for listeners that skip function bodies but still
parse expressions; it indicates to them whether they need to drop an
expression from their stack.

I will be adding such a listener in a future CL.

R=ahe@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/daa9d525e7d1f7b76a41b03fb6a0c8822efe4f08

[Paul Berry, 2017-03-10 20:10:55]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[scheglov, 2017-03-10 20:13:07]

LGTM

[ahe, 2017-03-13 12:19:32]

LGTM? :-)

I wonder if this is the right approach? An alternative is to have
skipFunctionBody call skipExpression instead of parseExpression.

[Paul Berry, 2017-03-13 17:18:42]

On 2017/03/13 12:19:32, ahe wrote:
> LGTM? :-)
> 
> I wonder if this is the right approach? An alternative is to have
> skipFunctionBody call skipExpression instead of parseExpression.

Hmm, good question.  I'm going to interpret your "LGTM?" as reluctant approval
and land this as is for now, since it unblocks other work I have in progress,
but I am open to more discussion about it.

In fact, I have been brewing some other ideas about how we might improve
"skipped" functionality which I intend to talk about in the next day or two. 
Let's revisit this CL at the time.

[Paul Berry, 2017-03-13 17:46:39]

Description was changed from

==========
Add an argument to handleFunctionBodySkipped.

This is necessary for listeners that skip function bodies but still
parse expressions; it indicates to them whether they need to drop an
expression from their stack.

I will be adding such a listener in a future CL.
==========

to

==========
Add an argument to handleFunctionBodySkipped.

This is necessary for listeners that skip function bodies but still
parse expressions; it indicates to them whether they need to drop an
expression from their stack.

I will be adding such a listener in a future CL.

R=ahe@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/daa9d525e7d1f7b76a41b03fb6a0c8822efe4f08
==========

[Paul Berry, 2017-03-13 17:46:40]

Committed patchset #1 (id:1) manually as
daa9d525e7d1f7b76a41b03fb6a0c8822efe4f08 (presubmit successful).

[ahe, 2017-03-14 12:04:54]

On 2017/03/13 17:18:42, Paul Berry wrote:
> On 2017/03/13 12:19:32, ahe wrote:
> > LGTM? :-)
> > 
> > I wonder if this is the right approach? An alternative is to have
> > skipFunctionBody call skipExpression instead of parseExpression.
> 
> Hmm, good question.  I'm going to interpret your "LGTM?" as reluctant approval
> and land this as is for now, since it unblocks other work I have in progress,
> but I am open to more discussion about it.

Absolutely, I intended for you to go ahead and do what you needed to do
short-term.
 
> In fact, I have been brewing some other ideas about how we might improve
> "skipped" functionality which I intend to talk about in the next day or two. 
> Let's revisit this CL at the time.

I look forward to that. There's a new crash in fasta due to "part of" with URLs.
I think this ties into skipping. I'll send you a CL, so you can factor that in
as well.