Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: pkg/compiler/lib/src/parser/member_listener.dart

Issue 2738013002: Add support for metadata on type variables to Fasta parser. (Closed)
Patch Set: Bug fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/parser/element_listener.dart ('k') | pkg/compiler/lib/src/parser/node_listener.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/parser/member_listener.dart
diff --git a/pkg/compiler/lib/src/parser/member_listener.dart b/pkg/compiler/lib/src/parser/member_listener.dart
index b1684cb1453481ea7859980a5df723ad5af8a664..2c4213e3583bb5429e3738e9b356cf3667ae0514 100644
--- a/pkg/compiler/lib/src/parser/member_listener.dart
+++ b/pkg/compiler/lib/src/parser/member_listener.dart
@@ -155,6 +155,15 @@ class MemberListener extends NodeListener {
@override
void endMetadata(Token beginToken, Token periodBeforeName, Token endToken) {
super.endMetadata(beginToken, periodBeforeName, endToken);
- pushMetadata(new PartialMetadataAnnotation(beginToken, endToken));
+ // TODO(paulberry,ahe): type variable metadata should not be ignored. See
+ // dartbug.com/5841.
+ if (!inTypeVariable) {
+ pushMetadata(new PartialMetadataAnnotation(beginToken, endToken));
+ }
+ }
+
+ @override
+ void endTypeVariable(Token token, Token extendsOrSuper) {
+ super.endTypeVariable(token, extendsOrSuper);
ahe 2017/03/13 15:36:47 Is this necessary?
Paul Berry 2017/03/13 17:01:08 Whoops, clearly no. I'm not sure what I was think
}
}
« no previous file with comments | « pkg/compiler/lib/src/parser/element_listener.dart ('k') | pkg/compiler/lib/src/parser/node_listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698