Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: components/omnibox/browser/zero_suggest_provider_unittest.cc

Issue 2738003002: Add title to current page in zero suggest. (Closed)
Patch Set: Add flag to show title for current URL suggestion. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/zero_suggest_provider_unittest.cc
diff --git a/components/omnibox/browser/zero_suggest_provider_unittest.cc b/components/omnibox/browser/zero_suggest_provider_unittest.cc
index e60556abd4c048972fe80e740a26213e1e9c3565..4224f8dfa536e765dadcd89b6426727e28f0756e 100644
--- a/components/omnibox/browser/zero_suggest_provider_unittest.cc
+++ b/components/omnibox/browser/zero_suggest_provider_unittest.cc
@@ -242,7 +242,7 @@ TEST_F(ZeroSuggestProviderTest, TestDoesNotReturnMatchesForPrefix) {
std::string url("http://www.cnn.com/");
AutocompleteInput input(base::ASCIIToUTF16(url), base::string16::npos,
- std::string(), GURL(url),
+ std::string(), GURL(url), base::string16(),
metrics::OmniboxEventProto::INVALID_SPEC, true, false,
true, true, false, TestSchemeClassifier());
@@ -270,7 +270,7 @@ TEST_F(ZeroSuggestProviderTest, TestMostVisitedCallback) {
std::string current_url("http://www.foxnews.com/");
std::string input_url("http://www.cnn.com/");
AutocompleteInput input(base::ASCIIToUTF16(input_url), base::string16::npos,
- std::string(), GURL(current_url),
+ std::string(), GURL(current_url), base::string16(),
metrics::OmniboxEventProto::OTHER, false, false, true,
true, true, TestSchemeClassifier());
history::MostVisitedURLList urls;
@@ -301,7 +301,7 @@ TEST_F(ZeroSuggestProviderTest, TestMostVisitedNavigateToSearchPage) {
std::string current_url("http://www.foxnews.com/");
std::string input_url("http://www.cnn.com/");
AutocompleteInput input(base::ASCIIToUTF16(input_url), base::string16::npos,
- std::string(), GURL(current_url),
+ std::string(), GURL(current_url), base::string16(),
metrics::OmniboxEventProto::OTHER, false, false, true,
true, true, TestSchemeClassifier());
history::MostVisitedURLList urls;
@@ -316,7 +316,7 @@ TEST_F(ZeroSuggestProviderTest, TestMostVisitedNavigateToSearchPage) {
std::string search_url("https://www.google.com/?q=flowers");
AutocompleteInput srp_input(
base::ASCIIToUTF16(search_url), base::string16::npos, std::string(),
- GURL(search_url),
+ GURL(search_url), base::string16(),
metrics::OmniboxEventProto::SEARCH_RESULT_PAGE_NO_SEARCH_TERM_REPLACEMENT,
false, false, true, true, true, TestSchemeClassifier());
@@ -337,7 +337,7 @@ TEST_F(ZeroSuggestProviderTest, TestPsuggestZeroSuggestCachingFirstRun) {
std::string url("http://www.cnn.com/");
AutocompleteInput input(base::ASCIIToUTF16(url), base::string16::npos,
- std::string(), GURL(url),
+ std::string(), GURL(url), base::string16(),
metrics::OmniboxEventProto::INVALID_SPEC, true, false,
true, true, true, TestSchemeClassifier());
@@ -367,7 +367,7 @@ TEST_F(ZeroSuggestProviderTest, TestPsuggestZeroSuggestHasCachedResults) {
std::string url("http://www.cnn.com/");
AutocompleteInput input(base::ASCIIToUTF16(url), base::string16::npos,
- std::string(), GURL(url),
+ std::string(), GURL(url), base::string16(),
metrics::OmniboxEventProto::INVALID_SPEC, true, false,
true, true, true, TestSchemeClassifier());
@@ -413,7 +413,7 @@ TEST_F(ZeroSuggestProviderTest, TestPsuggestZeroSuggestReceivedEmptyResults) {
std::string url("http://www.cnn.com/");
AutocompleteInput input(base::ASCIIToUTF16(url), base::string16::npos,
- std::string(), GURL(url),
+ std::string(), GURL(url), base::string16(),
metrics::OmniboxEventProto::INVALID_SPEC, true, false,
true, true, true, TestSchemeClassifier());

Powered by Google App Engine
This is Rietveld 408576698