Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: components/omnibox/browser/zero_suggest_provider_unittest.cc

Issue 2738003002: Add title to current page in zero suggest. (Closed)
Patch Set: Remove debugging info. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/omnibox/browser/zero_suggest_provider.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/zero_suggest_provider_unittest.cc
diff --git a/components/omnibox/browser/zero_suggest_provider_unittest.cc b/components/omnibox/browser/zero_suggest_provider_unittest.cc
index 8bb0e48217456359f0532d1c3ca9b48dcfcb68c0..1d3ac0bc74a6c4f40556d0afed92300f13adb67d 100644
--- a/components/omnibox/browser/zero_suggest_provider_unittest.cc
+++ b/components/omnibox/browser/zero_suggest_provider_unittest.cc
@@ -243,7 +243,7 @@ TEST_F(ZeroSuggestProviderTest, TestDoesNotReturnMatchesForPrefix) {
std::string url("http://www.cnn.com/");
AutocompleteInput input(base::ASCIIToUTF16(url), base::string16::npos,
- std::string(), GURL(url),
+ std::string(), GURL(url), base::string16(),
metrics::OmniboxEventProto::INVALID_SPEC, true, false,
true, true, false, TestSchemeClassifier());
@@ -271,7 +271,7 @@ TEST_F(ZeroSuggestProviderTest, TestMostVisitedCallback) {
std::string current_url("http://www.foxnews.com/");
std::string input_url("http://www.cnn.com/");
AutocompleteInput input(base::ASCIIToUTF16(input_url), base::string16::npos,
- std::string(), GURL(current_url),
+ std::string(), GURL(current_url), base::string16(),
metrics::OmniboxEventProto::OTHER, false, false, true,
true, true, TestSchemeClassifier());
history::MostVisitedURLList urls;
@@ -302,7 +302,7 @@ TEST_F(ZeroSuggestProviderTest, TestMostVisitedNavigateToSearchPage) {
std::string current_url("http://www.foxnews.com/");
std::string input_url("http://www.cnn.com/");
AutocompleteInput input(base::ASCIIToUTF16(input_url), base::string16::npos,
- std::string(), GURL(current_url),
+ std::string(), GURL(current_url), base::string16(),
metrics::OmniboxEventProto::OTHER, false, false, true,
true, true, TestSchemeClassifier());
history::MostVisitedURLList urls;
@@ -317,7 +317,7 @@ TEST_F(ZeroSuggestProviderTest, TestMostVisitedNavigateToSearchPage) {
std::string search_url("https://www.google.com/?q=flowers");
AutocompleteInput srp_input(
base::ASCIIToUTF16(search_url), base::string16::npos, std::string(),
- GURL(search_url),
+ GURL(search_url), base::string16(),
metrics::OmniboxEventProto::SEARCH_RESULT_PAGE_NO_SEARCH_TERM_REPLACEMENT,
false, false, true, true, true, TestSchemeClassifier());
@@ -338,7 +338,7 @@ TEST_F(ZeroSuggestProviderTest, TestPsuggestZeroSuggestCachingFirstRun) {
std::string url("http://www.cnn.com/");
AutocompleteInput input(base::ASCIIToUTF16(url), base::string16::npos,
- std::string(), GURL(url),
+ std::string(), GURL(url), base::string16(),
metrics::OmniboxEventProto::INVALID_SPEC, true, false,
true, true, true, TestSchemeClassifier());
@@ -368,7 +368,7 @@ TEST_F(ZeroSuggestProviderTest, TestPsuggestZeroSuggestHasCachedResults) {
std::string url("http://www.cnn.com/");
AutocompleteInput input(base::ASCIIToUTF16(url), base::string16::npos,
- std::string(), GURL(url),
+ std::string(), GURL(url), base::string16(),
metrics::OmniboxEventProto::INVALID_SPEC, true, false,
true, true, true, TestSchemeClassifier());
@@ -414,7 +414,7 @@ TEST_F(ZeroSuggestProviderTest, TestPsuggestZeroSuggestReceivedEmptyResults) {
std::string url("http://www.cnn.com/");
AutocompleteInput input(base::ASCIIToUTF16(url), base::string16::npos,
- std::string(), GURL(url),
+ std::string(), GURL(url), base::string16(),
metrics::OmniboxEventProto::INVALID_SPEC, true, false,
true, true, true, TestSchemeClassifier());
« no previous file with comments | « components/omnibox/browser/zero_suggest_provider.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698