Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: components/omnibox/browser/physical_web_provider_unittest.cc

Issue 2738003002: Add title to current page in zero suggest. (Closed)
Patch Set: Remove debugging info. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/physical_web_provider_unittest.cc
diff --git a/components/omnibox/browser/physical_web_provider_unittest.cc b/components/omnibox/browser/physical_web_provider_unittest.cc
index d9d8dc987ab172d9b72236cd66325021ea42ba40..bc2b4b279662b780b54a4689a78836f6da4a0f8e 100644
--- a/components/omnibox/browser/physical_web_provider_unittest.cc
+++ b/components/omnibox/browser/physical_web_provider_unittest.cc
@@ -136,6 +136,7 @@ class PhysicalWebProviderTest : public testing::Test {
static AutocompleteInput CreateInputForNTP() {
return AutocompleteInput(
base::string16(), base::string16::npos, std::string(), GURL(),
+ base::string16(),
metrics::OmniboxEventProto::INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS,
false, false, true, true, true, TestSchemeClassifier());
}
@@ -144,7 +145,7 @@ class PhysicalWebProviderTest : public testing::Test {
// as the current web page.
static AutocompleteInput CreateInputWithCurrentUrl(const std::string& url) {
return AutocompleteInput(base::UTF8ToUTF16(url), base::string16::npos,
- std::string(), GURL(url),
+ std::string(), GURL(url), base::string16(),
metrics::OmniboxEventProto::OTHER, false, false,
true, true, true, TestSchemeClassifier());
}
@@ -325,6 +326,7 @@ TEST_F(PhysicalWebProviderTest, TestNoMatchesWithUserInput) {
std::string text("user input");
const AutocompleteInput input(
base::UTF8ToUTF16(text), text.length(), std::string(), GURL(),
+ base::string16(),
metrics::OmniboxEventProto::INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS,
true, false, true, true, false, TestSchemeClassifier());
provider_->Start(input, false);
@@ -343,7 +345,7 @@ TEST_F(PhysicalWebProviderTest, TestEmptyInputAfterTyping) {
// user typed a query and then deleted it. The provider should generate
// suggestions for the zero-suggest case. No default match should be created.
const AutocompleteInput input(
- base::string16(), 0, std::string(), GURL(),
+ base::string16(), 0, std::string(), GURL(), base::string16(),
metrics::OmniboxEventProto::INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS,
true, false, true, true, false, TestSchemeClassifier());
provider_->Start(input, false);
@@ -437,7 +439,7 @@ TEST_F(PhysicalWebProviderTest, TestNearbyURLCountHistograms) {
AutocompleteInput zero_suggest_input(CreateInputForNTP());
AutocompleteInput after_typing_input(
- base::UTF8ToUTF16("Example"), 7, std::string(), GURL(),
+ base::UTF8ToUTF16("Example"), 7, std::string(), GURL(), base::string16(),
metrics::OmniboxEventProto::INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS,
true, false, true, true, false, TestSchemeClassifier());
@@ -487,7 +489,7 @@ TEST_F(PhysicalWebProviderTest, TestNearbyURLCountAfterTypingWithoutFocus) {
EXPECT_TRUE(data_source);
AutocompleteInput after_typing_input(
- base::UTF8ToUTF16("Example"), 7, std::string(), GURL(),
+ base::UTF8ToUTF16("Example"), 7, std::string(), GURL(), base::string16(),
metrics::OmniboxEventProto::INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS,
true, false, true, true, false, TestSchemeClassifier());
« no previous file with comments | « components/omnibox/browser/physical_web_provider.cc ('k') | components/omnibox/browser/shortcuts_provider_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698