Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: components/omnibox/browser/keyword_provider_unittest.cc

Issue 2738003002: Add title to current page in zero suggest. (Closed)
Patch Set: Remove debugging info. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/keyword_provider_unittest.cc
diff --git a/components/omnibox/browser/keyword_provider_unittest.cc b/components/omnibox/browser/keyword_provider_unittest.cc
index 8c4e4bf7d8d5d646436fdf67e629d99ba35fb5bc..54955e540f89361929477944c2c842650b921007 100644
--- a/components/omnibox/browser/keyword_provider_unittest.cc
+++ b/components/omnibox/browser/keyword_provider_unittest.cc
@@ -132,8 +132,8 @@ void KeywordProviderTest::RunTest(TestData<ResultType>* keyword_cases,
SCOPED_TRACE(keyword_cases[i].input);
AutocompleteInput input(
keyword_cases[i].input, base::string16::npos, std::string(), GURL(),
- metrics::OmniboxEventProto::INVALID_SPEC, true, false, true, true,
- false, TestingSchemeClassifier());
+ base::string16(), metrics::OmniboxEventProto::INVALID_SPEC, true, false,
+ true, true, false, TestingSchemeClassifier());
kw_provider_->Start(input, false);
EXPECT_TRUE(kw_provider_->done());
matches = kw_provider_->matches();
@@ -499,11 +499,11 @@ TEST_F(KeywordProviderTest, GetSubstitutingTemplateURLForInput) {
};
SetUpClientAndKeywordProvider();
for (size_t i = 0; i < arraysize(cases); i++) {
- AutocompleteInput input(ASCIIToUTF16(cases[i].text),
- cases[i].cursor_position, std::string(), GURL(),
- metrics::OmniboxEventProto::INVALID_SPEC, false,
- false, cases[i].allow_exact_keyword_match, true,
- false, TestingSchemeClassifier());
+ AutocompleteInput input(
+ ASCIIToUTF16(cases[i].text), cases[i].cursor_position, std::string(),
+ GURL(), base::string16(), metrics::OmniboxEventProto::INVALID_SPEC,
+ false, false, cases[i].allow_exact_keyword_match, true, false,
+ TestingSchemeClassifier());
const TemplateURL* url =
KeywordProvider::GetSubstitutingTemplateURLForInput(
client_->GetTemplateURLService(), &input);
@@ -537,7 +537,7 @@ TEST_F(KeywordProviderTest, ExtraQueryParams) {
TEST_F(KeywordProviderTest, DoesNotProvideMatchesOnFocus) {
SetUpClientAndKeywordProvider();
AutocompleteInput input(ASCIIToUTF16("aaa"), base::string16::npos,
- std::string(), GURL(),
+ std::string(), GURL(), base::string16(),
metrics::OmniboxEventProto::INVALID_SPEC, true, false,
true, true, true, TestingSchemeClassifier());
kw_provider_->Start(input, false);
« no previous file with comments | « components/omnibox/browser/history_url_provider_unittest.cc ('k') | components/omnibox/browser/omnibox_edit_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698