components/omnibox/browser/bookmark_provider_unittest.cc - Issue 2738003002: Add title to current page in zero suggest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/bookmark_provider_unittest.cc

Issue 2738003002: Add title to current page in zero suggest. (Closed)

Patch Set: Remove debugging info. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/omnibox/browser/autocomplete_result_unittest.cc ('k') | components/omnibox/browser/builtin_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/bookmark_provider_unittest.cc

diff --git a/components/omnibox/browser/bookmark_provider_unittest.cc b/components/omnibox/browser/bookmark_provider_unittest.cc

index 586892e3cd382ba38d3c8963d216d436db526a72..28ff8ca56551a813bf2e3acbfb7dfc83b8e412fd 100644

--- a/components/omnibox/browser/bookmark_provider_unittest.cc

+++ b/components/omnibox/browser/bookmark_provider_unittest.cc

@@ -279,6 +279,7 @@ TEST_F(BookmarkProviderTest, Positions) {

for (size_t i = 0; i < arraysize(query_data); ++i) {

AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),

base::string16::npos, std::string(), GURL(),

+ base::string16(),

metrics::OmniboxEventProto::INVALID_SPEC, false,

false, false, true, false, TestSchemeClassifier());

provider_->Start(input, false);

@@ -359,6 +360,7 @@ TEST_F(BookmarkProviderTest, Rankings) {

for (size_t i = 0; i < arraysize(query_data); ++i) {

AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),

base::string16::npos, std::string(), GURL(),

+ base::string16(),

metrics::OmniboxEventProto::INVALID_SPEC, false,

false, false, true, false, TestSchemeClassifier());

provider_->Start(input, false);

@@ -415,6 +417,7 @@ TEST_F(BookmarkProviderTest, InlineAutocompletion) {

" and url=" + query_data[i].url;

AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),

base::string16::npos, std::string(), GURL(),

+ base::string16(),

metrics::OmniboxEventProto::INVALID_SPEC, false,

false, false, true, false, TestSchemeClassifier());

const base::string16 fixed_up_input(

@@ -459,6 +462,7 @@ TEST_F(BookmarkProviderTest, StripHttpAndAdjustOffsets) {

std::string description = "for query=" + query_data[i].query;

AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),

base::string16::npos, std::string(), GURL(),

+ base::string16(),

metrics::OmniboxEventProto::INVALID_SPEC, false,

false, false, true, false, TestSchemeClassifier());

provider_->Start(input, false);

@@ -488,7 +492,7 @@ TEST_F(BookmarkProviderTest, StripHttpAndAdjustOffsets) {

TEST_F(BookmarkProviderTest, DoesNotProvideMatchesOnFocus) {

AutocompleteInput input(base::ASCIIToUTF16("foo"), base::string16::npos,

- std::string(), GURL(),

+ std::string(), GURL(), base::string16(),

metrics::OmniboxEventProto::INVALID_SPEC, false,

false, false, true, true, TestSchemeClassifier());

provider_->Start(input, false);