Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1700)

Unified Diff: components/omnibox/browser/physical_web_provider.cc

Issue 2738003002: Add title to current page in zero suggest. (Closed)
Patch Set: Added description as a param to VerbatimMatchForURL Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/physical_web_provider.cc
diff --git a/components/omnibox/browser/physical_web_provider.cc b/components/omnibox/browser/physical_web_provider.cc
index ae43be5f143101ae37d6b4652c8ace96c01a404d..7ee6915b9fc038071628ecff9a8b852489f27d93 100644
--- a/components/omnibox/browser/physical_web_provider.cc
+++ b/components/omnibox/browser/physical_web_provider.cc
@@ -102,8 +102,9 @@ void PhysicalWebProvider::Start(const AutocompleteInput& input,
// the omnibox causes the current page to reload. If the input field is
// empty, no default match is required.
if (!matches_.empty() && !input.text().empty()) {
- matches_.push_back(VerbatimMatchForURL(
- client_, input, input.current_url(), history_url_provider_, -1));
+ matches_.push_back(
+ VerbatimMatchForURL(client_, input, input.current_url(),
Mark P 2017/04/13 21:12:28 Please use the title of the current page here too
gcomanici 2017/04/18 18:52:52 Done.
+ base::string16(), history_url_provider_, -1));
}
} else {
ConstructQuerySuggestMatches(std::move(metadata_list), input);

Powered by Google App Engine
This is Rietveld 408576698