Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: components/omnibox/browser/omnibox_field_trial.h

Issue 2738003002: Add title to current page in zero suggest. (Closed)
Patch Set: Add flag to show title for current URL suggestion. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_ 5 #ifndef COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_
6 #define COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_ 6 #define COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
11 #include <map> 11 #include <map>
12 #include <string> 12 #include <string>
13 #include <vector> 13 #include <vector>
14 14
15 #include "base/macros.h" 15 #include "base/macros.h"
16 #include "components/metrics/proto/omnibox_event.pb.h" 16 #include "components/metrics/proto/omnibox_event.pb.h"
17 #include "components/omnibox/browser/autocomplete_input.h" 17 #include "components/omnibox/browser/autocomplete_input.h"
18 #include "components/omnibox/browser/autocomplete_match_type.h" 18 #include "components/omnibox/browser/autocomplete_match_type.h"
19 19
20 namespace base { 20 namespace base {
21 struct Feature; 21 struct Feature;
22 class TimeDelta; 22 class TimeDelta;
23 } 23 }
24 24
25 namespace omnibox { 25 namespace omnibox {
26 26
27 extern const base::Feature kIncludeTitleToACMatchForCurrentUrl;
Mark P 2017/04/10 22:38:02 ACMatch seems unnecessary here. Perhaps kDisplayT
Mark P 2017/04/10 22:38:02 nit: please add to the bottom. (We've been workin
gcomanici 2017/04/11 20:51:41 Done.
gcomanici 2017/04/11 20:51:41 Done.
27 extern const base::Feature kNewOmniboxAnswerTypes; 28 extern const base::Feature kNewOmniboxAnswerTypes;
28 extern const base::Feature kOmniboxEntitySuggestions; 29 extern const base::Feature kOmniboxEntitySuggestions;
29 extern const base::Feature kEnableClipboardProvider; 30 extern const base::Feature kEnableClipboardProvider;
30 extern const base::Feature kSearchProviderWarmUpOnFocus; 31 extern const base::Feature kSearchProviderWarmUpOnFocus;
31 extern const base::Feature kSearchProviderContextAllowHttpsUrls; 32 extern const base::Feature kSearchProviderContextAllowHttpsUrls;
32 extern const base::Feature kZeroSuggestRedirectToChrome; 33 extern const base::Feature kZeroSuggestRedirectToChrome;
33 extern const base::Feature kZeroSuggestSwapTitleAndUrl; 34 extern const base::Feature kZeroSuggestSwapTitleAndUrl;
34 } 35 }
35 36
36 // The set of parameters customizing the HUP scoring. 37 // The set of parameters customizing the HUP scoring.
(...skipping 471 matching lines...) Expand 10 before | Expand all | Expand 10 after
508 // prioritize different wildcard contexts, see the implementation. How to 509 // prioritize different wildcard contexts, see the implementation. How to
509 // interpret the value is left to the caller; this is rule-dependent. 510 // interpret the value is left to the caller; this is rule-dependent.
510 static std::string GetValueForRuleInContext( 511 static std::string GetValueForRuleInContext(
511 const std::string& rule, 512 const std::string& rule,
512 metrics::OmniboxEventProto::PageClassification page_classification); 513 metrics::OmniboxEventProto::PageClassification page_classification);
513 514
514 DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial); 515 DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
515 }; 516 };
516 517
517 #endif // COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_ 518 #endif // COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698