chrome/browser/flag_descriptions.h - Issue 2738003002: Add title to current page in zero suggest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/flag_descriptions.h

Issue 2738003002: Add title to current page in zero suggest. (Closed)

Patch Set: Add flag to show title for current URL suggestion. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/about_flags.cc ('K') | « chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc ('k') | chrome/browser/flag_descriptions.cc » ('j') | chrome/browser/flag_descriptions.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_FLAG_DESCRIPTIONS_H_	5 #ifndef CHROME_BROWSER_FLAG_DESCRIPTIONS_H_

6 #define CHROME_BROWSER_FLAG_DESCRIPTIONS_H_	6 #define CHROME_BROWSER_FLAG_DESCRIPTIONS_H_

7	7

8 // Includes needed for macros allowing conditional compilation of some strings.	8 // Includes needed for macros allowing conditional compilation of some strings.

9 #include "build/build_config.h"	9 #include "build/build_config.h"

10 #include "build/buildflag.h"	10 #include "build/buildflag.h"

(...skipping 3138 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
3149 // Name of the about: flag for enabling emoji, handwriting and voice input on	3149 // Name of the about: flag for enabling emoji, handwriting and voice input on

3150 // opt-in IME menu.	3150 // opt-in IME menu.

3151 extern const char kEnableEhvInputName[];	3151 extern const char kEnableEhvInputName[];

3152	3152

3153 // Description of the about: flag enabling emoji, handwriting and voice input on	3153 // Description of the about: flag enabling emoji, handwriting and voice input on

3154 // opt-in IME menu.	3154 // opt-in IME menu.

3155 extern const char kEnableEhvInputDescription[];	3155 extern const char kEnableEhvInputDescription[];

3156	3156

3157 #endif // #if defined(OS_CHROMEOS)	3157 #endif // #if defined(OS_CHROMEOS)

3158	3158

	3159 // Name for the about: flag for including the title to auto complete match for
	Mark P 2017/04/10 22:38:02 nit: "for the" -> "of the" (for consistency with t nit: "for the" -> "of the" (for consistency with the rest of this file) gcomanici 2017/04/11 20:51:41 Done. Show quoted text On 2017/04/10 22:38:02, Mark P wrote: > nit: "for the" -> "of the" > (for consistency with the rest of this file) Done.
	3160 // current URL.

	3161 extern const char kIncludeTitleToACMatchForCurrentUrlName[];
	Mark P 2017/04/10 22:38:02 Please revise this variable name and comment to be Please revise this variable name and comment to be similar to the (revised) feature name. But also include "omnibox" in there somewhere for easy searching. ditto below gcomanici 2017/04/11 20:51:41 Done. Show quoted text On 2017/04/10 22:38:02, Mark P wrote: > Please revise this variable name and comment to be similar to the (revised) > feature name. > But also include "omnibox" in there somewhere for easy searching. > ditto below Done.
	3162

	3163 // Description for the about: flag for including the title to auto complete

	3164 // match for current URL.

	3165 extern const char kIncludeTitleToACMatchForCurrentUrlDescription[];

	3166

3159 } // namespace flag_descriptions	3167 } // namespace flag_descriptions

3160	3168

3161 #endif // CHROME_BROWSER_FLAG_DESCRIPTIONS_H_	3169 #endif // CHROME_BROWSER_FLAG_DESCRIPTIONS_H_

OLD	NEW