chrome/browser/flag_descriptions.h - Issue 2738003002: Add title to current page in zero suggest.

Side by Side Diff: chrome/browser/flag_descriptions.h

Issue 2738003002: Add title to current page in zero suggest. (Closed)

Patch Set: Change the place where the title is added and some suggested renaming. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/android/vr_shell/vr_omnibox.cc ('K') | « chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc ('k') | chrome/browser/flag_descriptions.cc » ('j') | chrome/browser/flag_descriptions.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_FLAG_DESCRIPTIONS_H_	5 #ifndef CHROME_BROWSER_FLAG_DESCRIPTIONS_H_

6 #define CHROME_BROWSER_FLAG_DESCRIPTIONS_H_	6 #define CHROME_BROWSER_FLAG_DESCRIPTIONS_H_

7	7

8 // Includes needed for macros allowing conditional compilation of some strings.	8 // Includes needed for macros allowing conditional compilation of some strings.

9 #include "build/build_config.h"	9 #include "build/build_config.h"

10 #include "build/buildflag.h"	10 #include "build/buildflag.h"

(...skipping 3200 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
3211 #if defined(OS_ANDROID)	3211 #if defined(OS_ANDROID)

3212	3212

3213 // Name of the flag that enables Copyless Paste.	3213 // Name of the flag that enables Copyless Paste.

3214 extern const char kEnableCopylessPasteName[];	3214 extern const char kEnableCopylessPasteName[];

3215	3215

3216 // Description of the flag that enables Copyless Paste.	3216 // Description of the flag that enables Copyless Paste.

3217 extern const char kEnableCopylessPasteDescription[];	3217 extern const char kEnableCopylessPasteDescription[];

3218	3218

3219 #endif // defined(OS_ANDROID)	3219 #endif // defined(OS_ANDROID)

3220	3220

	3221 // Name of the about: flag for displaying the title to omnibox auto complete
	Mark P 2017/04/12 05:07:56 I'm not sure what you meant here by this sentence I'm not sure what you meant here by this sentence (there might be a typo or two). Did you mean: // Name of the about: flag for displaying the title of the omnibox match for current URL. ? gcomanici 2017/04/12 16:16:30 Done. Show quoted text On 2017/04/12 05:07:56, Mark P wrote: > I'm not sure what you meant here by this sentence (there might be a typo or > two). Did you mean: > // Name of the about: flag for displaying the title of the omnibox match for > current URL. > ? Done.
	3222 // match for current URL.

	3223 extern const char kOmniboxDisplayTitleForCurrentUrlName[];

	3224

	3225 // Description of the about: flag g for displaying the title to omnibox auto
	Mark P 2017/04/12 05:07:56 Another typo "g" :-P , plus a copy and paste erro Another typo "g" :-P , plus a copy and paste error. How about taking the corrected sentence above and swapping "Title" for "Description"? gcomanici 2017/04/12 16:16:30 Done. Sorry about that. We should have some lintin Show quoted text On 2017/04/12 05:07:56, Mark P wrote: > Another typo "g" :-P , plus a copy and paste error. > How about taking the corrected sentence above and swapping "Title" for > "Description"? > Done. Sorry about that. We should have some linting to figure out awkward grammar and spelling errors in comments. Mark P 2017/04/12 17:58:46 What a fun idea. "lint" runs a grammar checker. : Show quoted text On 2017/04/12 16:16:30, gcomanici wrote: > On 2017/04/12 05:07:56, Mark P wrote: > > Another typo "g" :-P , plus a copy and paste error. > > How about taking the corrected sentence above and swapping "Title" for > > "Description"? > > > > Done. Sorry about that. We should have some linting to figure out awkward > grammar and spelling errors in comments. What a fun idea. "lint" runs a grammar checker. :-)
	3226 // complete match for current URL. match for current URL.

	3227 extern const char kOmniboxDisplayTitleForCurrentUrlDescription[];

	3228

3221 } // namespace flag_descriptions	3229 } // namespace flag_descriptions

3222	3230

3223 #endif // CHROME_BROWSER_FLAG_DESCRIPTIONS_H_	3231 #endif // CHROME_BROWSER_FLAG_DESCRIPTIONS_H_

OLD	NEW