content/browser/gpu/gpu_data_manager_impl_private_unittest.cc - Issue 2737983002: WebGL feature will only enabled when accelerated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

Issue 2737983002: WebGL feature will only enabled when accelerated (Closed)

Patch Set: WebGL and WebGL2 features will only enabled when accelerated Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/gpu/gpu_data_manager_impl_private.cc ('K') | « content/browser/gpu/gpu_data_manager_impl_private.cc ('k') | content/public/browser/gpu_data_manager.h » ('j') | gpu/config/gpu_blacklist.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

diff --git a/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc b/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

index 880a83fe77f85d13a6bc49778cb7ce6e6645addc..a5123c84251376bf94e7b335be4bf0168c992372 100644

--- a/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

+++ b/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

@@ -595,7 +595,8 @@ TEST_F(GpuDataManagerImplPrivateTest, SetGLStrings) {

manager->SetGLStrings(kGLVendorMesa, kGLRendererMesa, kGLVersionMesa801);

EXPECT_TRUE(manager->GpuAccessAllowed(NULL));

EXPECT_EQ(1u, manager->GetBlacklistedFeatureCount());

- EXPECT_TRUE(manager->IsFeatureBlacklisted(gpu::GPU_FEATURE_TYPE_WEBGL));

+ EXPECT_TRUE(

+ manager->IsFeatureBlacklisted(gpu::GPU_FEATURE_TYPE_ACCELERATED_WEBGL));

}

TEST_F(GpuDataManagerImplPrivateTest, SetGLStringsNoEffects) {

@@ -645,7 +646,8 @@ TEST_F(GpuDataManagerImplPrivateTest, SetGLStringsNoEffects) {

// Full GPUInfo, the entry applies.

EXPECT_TRUE(manager->GpuAccessAllowed(NULL));

EXPECT_EQ(1u, manager->GetBlacklistedFeatureCount());

- EXPECT_TRUE(manager->IsFeatureBlacklisted(gpu::GPU_FEATURE_TYPE_WEBGL));

+ EXPECT_TRUE(

+ manager->IsFeatureBlacklisted(gpu::GPU_FEATURE_TYPE_ACCELERATED_WEBGL));

// Now assume browser gets GL strings from local state.

// SetGLStrings() has no effects because GPUInfo already got these strings.

@@ -653,7 +655,8 @@ TEST_F(GpuDataManagerImplPrivateTest, SetGLStringsNoEffects) {

manager->SetGLStrings(kGLVendorMesa, kGLRendererMesa, kGLVersionMesa802);

EXPECT_TRUE(manager->GpuAccessAllowed(NULL));

EXPECT_EQ(1u, manager->GetBlacklistedFeatureCount());

- EXPECT_TRUE(manager->IsFeatureBlacklisted(gpu::GPU_FEATURE_TYPE_WEBGL));

+ EXPECT_TRUE(

+ manager->IsFeatureBlacklisted(gpu::GPU_FEATURE_TYPE_ACCELERATED_WEBGL));

}

TEST_F(GpuDataManagerImplPrivateTest, SetGLStringsDefered) {

@@ -690,7 +693,8 @@ TEST_F(GpuDataManagerImplPrivateTest, SetGLStringsDefered) {

EXPECT_TRUE(manager->GpuAccessAllowed(NULL));

EXPECT_EQ(1u, manager->GetBlacklistedFeatureCount());

- EXPECT_TRUE(manager->IsFeatureBlacklisted(gpu::GPU_FEATURE_TYPE_WEBGL));

+ EXPECT_TRUE(

+ manager->IsFeatureBlacklisted(gpu::GPU_FEATURE_TYPE_ACCELERATED_WEBGL));

}

#endif // OS_LINUX