extensions/common/manifest_handlers/requirements_info.cc - Issue 2737983002: WebGL feature will only enabled when accelerated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/requirements_info.cc

Issue 2737983002: WebGL feature will only enabled when accelerated (Closed)

Patch Set: Reverted WebGL2 change and renamed wegl -> accelerated_webgl Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/manifest_handlers/requirements_info.cc

diff --git a/extensions/common/manifest_handlers/requirements_info.cc b/extensions/common/manifest_handlers/requirements_info.cc

index d73af89c0902de0c689f704675ed6525e5980fdc..90de4398a45de6b4fa6ed1b533f174158e78a2bc 100644

--- a/extensions/common/manifest_handlers/requirements_info.cc

+++ b/extensions/common/manifest_handlers/requirements_info.cc

@@ -118,7 +118,7 @@ bool RequirementsHandler::Parse(Extension* extension, base::string16* error) {

feature_iter != features->end(); ++feature_iter) {

std::string feature;

if ((*feature_iter)->GetAsString(&feature)) {

- if (feature == "webgl") {

+ if (feature == "accelerated_webgl") {

sugoi1 2017/03/10 21:22:03 I think this one is wrong, will revert.

requirements->webgl = true;

} else if (feature == "css3d") {

// css3d is always available, so no check is needed, but no error is

« no previous file with comments | « content/public/browser/gpu_data_manager.h ('k') | gpu/config/gpu_blacklist.cc » ('j') | no next file with comments »