components/autofill/core/browser/autofill_metrics_unittest.cc - Issue 2737953002: UKM: Remove UkmService::RecordSource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_metrics_unittest.cc

Issue 2737953002: UKM: Remove UkmService::RecordSource (Closed)

Patch Set: fix error from rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_metrics_unittest.cc

diff --git a/components/autofill/core/browser/autofill_metrics_unittest.cc b/components/autofill/core/browser/autofill_metrics_unittest.cc

index 36039f5f382fd2ec4a5eefbe9cb9b8072fb09d69..efea6e76cab0aafd11a2a5053fff1cb525bda757 100644

--- a/components/autofill/core/browser/autofill_metrics_unittest.cc

+++ b/components/autofill/core/browser/autofill_metrics_unittest.cc

@@ -4385,7 +4385,8 @@ TEST_F(AutofillMetricsTest, RecordCardUploadDecisionMetric) {

ukm_service_test_harness.test_ukm_service();

ASSERT_EQ(1U, ukm_service->sources_count());

- const ukm::UkmSource* source = ukm_service->GetSource(0);

+ const ukm::UkmSource* source =

+ ukm_service->GetSourceForUrl(url.spec().c_str());

EXPECT_EQ(url.spec(), source->url().spec());

EXPECT_EQ(1U, ukm_service->entries_count());